From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 30/32] net/ice: support basic RX/TX
Date: Fri, 14 Dec 2018 13:00:15 +0000
Message-ID: <1db7247c-5332-c344-2304-70a2133fc3d9@intel.com>
References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com>
 <1544776518-91047-1-git-send-email-wenzhuo.lu@intel.com>
 <1544776518-91047-31-git-send-email-wenzhuo.lu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Qiming Yang <qiming.yang@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>, Thomas Monjalon <thomas@monjalon.net>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id AE9951B45A
 for <dev@dpdk.org>; Fri, 14 Dec 2018 14:00:20 +0100 (CET)
In-Reply-To: <1544776518-91047-31-git-send-email-wenzhuo.lu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/14/2018 8:35 AM, Wenzhuo Lu wrote:
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>

<...>

> +
> +	/* Check to make sure the last descriptor to clean is done */
> +	desc_to_clean_to = sw_ring[desc_to_clean_to].last_id;
> +	if (!(txd[desc_to_clean_to].cmd_type_offset_bsz &
> +	    rte_cpu_to_le_64(ICE_TX_DESC_DTYPE_DESC_DONE))) {
> +		PMD_TX_FREE_LOG(DEBUG, "TX descriptor %4u is not done "
> +				"(port=%d queue=%d) value=0x%lx\n",
> +				desc_to_clean_to,
> +				txq->port_id, txq->queue_id,
> +				txd[desc_to_clean_to].cmd_type_offset_bsz);

Causing build error for i686 [1], should use PRIx64 for 64bit variables.

Perhaps we should create a rule in checkpatch to check and warn %lx %lu formats
`git grep -n '%l[xud]' drivers/net/ice/` shows only this occurrence in 'ice' but
there are more in other drivers...


[1]
In file included from .../i686-native-linuxapp-gcc/include/rte_ethdev.h:150,
                 from .../i686-native-linuxapp-gcc/include/rte_ethdev_driver.h:18,
                 from .../drivers/net/ice/ice_lan_rxtx.c:5:
.../drivers/net/ice/ice_lan_rxtx.c: In function ‘ice_xmit_cleanup’:
.../drivers/net/ice/ice_lan_rxtx.c:1776:46: error: format ‘%lx’ expects argument
of type ‘long unsigned int’, but argument 8 has type ‘uint64_t’ {aka ‘volatile
long long unsigned int’} [-Werror=format=]
     txd[desc_to_clean_to].cmd_type_offset_bsz);
                                              ^
.../i686-native-linuxapp-gcc/include/rte_log.h:322:25: note: in definition of
macro ‘RTE_LOG’
    RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__)
                         ^
.../drivers/net/ice/ice_lan_rxtx.c:1772:3: note: in expansion of macro
‘PMD_TX_FREE_LOG’
   PMD_TX_FREE_LOG(DEBUG, "TX descriptor %4u is not done "
   ^~~~~~~~~~~~~~~