From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pascal Mazon Subject: [PATCH v2 4/4] net/tap: set MTU on the remote Date: Tue, 7 Mar 2017 17:38:54 +0100 Message-ID: <1dd6154aedbf8d3766a24a35136e58b0824cbfda.1488904606.git.pascal.mazon@6wind.com> References: Cc: dev@dpdk.org, Pascal Mazon To: keith.wiles@intel.com Return-path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 3B9FC2BAA for ; Tue, 7 Mar 2017 17:39:19 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Pascal Mazon --- drivers/net/tap/rte_eth_tap.c | 29 +++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index ed71cddfe0b3..34e56813cedb 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -839,9 +839,8 @@ tap_set_mc_addr_list(struct rte_eth_dev *dev __rte_unused, } static int -tap_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) +tap_netdev_mtu_set(const char *iface, uint16_t mtu) { - struct pmd_internals *pmd = dev->data->dev_private; struct ifreq ifr; int err, s; @@ -849,15 +848,15 @@ tap_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) if (s < 0) { RTE_LOG(ERR, PMD, "Unable to get a socket for %s to set flags: %s\n", - pmd->name, strerror(errno)); + iface, strerror(errno)); return -1; } memset(&ifr, 0, sizeof(ifr)); - snprintf(ifr.ifr_name, IFNAMSIZ, "%s", pmd->name); + snprintf(ifr.ifr_name, IFNAMSIZ, "%s", iface); err = ioctl(s, SIOCGIFMTU, &ifr); if (err < 0) { RTE_LOG(WARNING, PMD, "Unable to get %s device MTU: %s\n", - pmd->name, strerror(errno)); + iface, strerror(errno)); close(s); return -1; } @@ -865,11 +864,29 @@ tap_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) err = ioctl(s, SIOCSIFMTU, &ifr); if (err < 0) { RTE_LOG(WARNING, PMD, "Unable to set %s mtu %d: %s\n", - pmd->name, mtu, strerror(errno)); + iface, mtu, strerror(errno)); close(s); return -1; } close(s); + return 0; +} + +static int +tap_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) +{ + struct pmd_internals *pmd = dev->data->dev_private; + int err; + + /* First try to set mtu on the remote */ + if (pmd->remote_if_index) { + err = tap_netdev_mtu_set(pmd->remote_iface, mtu); + if (err < 0) + return err; + } + err = tap_netdev_mtu_set(pmd->name, mtu); + if (err < 0) + return err; dev->data->mtu = mtu; return 0; } -- 2.8.0.rc0