From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH] Create kern folder for Linux kernel modules
Date: Fri, 22 Dec 2017 15:34:47 +0530
Message-ID: <1e293147-9c72-9e77-97cb-9aabc9e5af39@nxp.com>
References: <1513922231-15554-1-git-send-email-hemant.agrawal@nxp.com>
 <2388140.F1AUfV8GGA@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0051.outbound.protection.outlook.com [104.47.33.51])
 by dpdk.org (Postfix) with ESMTP id 69B881B365
 for <dev@dpdk.org>; Fri, 22 Dec 2017 11:04:52 +0100 (CET)
In-Reply-To: <2388140.F1AUfV8GGA@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/22/2017 2:13 PM, Thomas Monjalon wrote:
> Hi,
>
> 22/12/2017 06:57, Hemant Agrawal:
>> This patch moves the Linux kernel modules code to a common place.
>>  - Separate the kernel module code from user space code.
>>  - The GPL-2.0 licensed code is separated from the BSD-3 licensed userspace
>>    code
>
> What is the benefit of separate things by license?

The separation makes it easy to identify and check the license.

Any patch introducing new file in *non-kern* folders shall not be 
GPL-2.0 licensed.  Or GPL-2.0 license is allowed only for kern folder.

> These modules are Linux modules, so they should be in the linuxapp dir.


This is a cleaner separation w.r.t userspace/kernel space code.
*kern* is a better placefolder for LKMs.

Also eal is not getting overloaded.

linuxapp is part of librte_eal.  KNI is not related to EAL, but still 
the kni kernel code is added to librte_eal under linuxapp.


> There are also some kernel modules in the bsdapp directory.

We can move them as well.

>
>