From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] eal: remove vdev probe by dev args
Date: Fri, 9 Jun 2017 10:21:02 +0100
Message-ID: <1eae2dda-3fb3-1d46-5d45-1493c1fe1cd4@intel.com>
References: <20170510110104.70838-1-ferruh.yigit@intel.com>
 <136091512.oDuubpNRB2@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, Jan Blunck <jblunck@infradead.org>,
 Gaetan Rivet <gaetan.rivet@6wind.com>, Tetsuya Mukawa <mtetsuyah@gmail.com>,
 Declan Doherty <declan.doherty@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 4128B2BA3
 for <dev@dpdk.org>; Fri,  9 Jun 2017 11:21:04 +0200 (CEST)
In-Reply-To: <136091512.oDuubpNRB2@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/8/2017 9:45 PM, Thomas Monjalon wrote:
> 10/05/2017 13:01, Ferruh Yigit:
>> Virtual device/driver probing done via name.
>>
>> A new alternative method introduced to probe the device with providing
>> driver name in devargs as "driver=<driver_name>".
>>
>> This patch removes alternative method and fixes virtual device usages
>> with proper device names.
>>
>> Fixes: 87c3bf29c642 ("test: do not short-circuit null device creation")
>> Fixes: d39670086a63 ("eal: parse driver argument before probing drivers")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
> [...]
>>  static int
>>  vdev_probe_all_drivers(struct rte_vdev_device *dev)
>>  {
>>  	const char *name;
>> -	char *drv_name;
>>  	struct rte_vdev_driver *driver;
>>  	int ret = 1;
>>  
>> -	drv_name = parse_driver_arg(rte_vdev_device_args(dev));
>> -	name = drv_name ? drv_name : rte_vdev_device_name(dev);
>> +	name = rte_vdev_device_name(dev);
> 
> It seems you are reverting the commit d39670086a63:
>     eal: parse driver argument before probing drivers

Mostly yes.

>     
>     In some cases the virtual device name should be totally different than
>     the driver being used for the device. Therefore lets parse the devargs for
>     the "driver" argument before probing drivers in vdev_probe_all_drivers().
> 
> Is this "driver" option useless?

There is already a generic way to probe, why need another method, I
didn't get the motivation but this looks like a hack, only place I found
used is in bonding unit test, which can be switched to generic way
without this support.

And this is a hidden / an undocumented feature.

Thanks,
ferruh