From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH 00/11] Support flow API in Solarflare PMD
Date: Tue, 7 Mar 2017 17:56:43 +0300
Message-ID: <1ec06a0a-c320-ea3d-0de9-00117f72e484@solarflare.com>
References: <1488470591-5853-1-git-send-email-arybchenko@solarflare.com>
 <ec2824ba-6beb-7582-b238-8d66c6955e1e@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from nbfkord-smmo01.seg.att.com (nbfkord-smmo01.seg.att.com
 [209.65.160.76]) by dpdk.org (Postfix) with ESMTP id 5576E108A
 for <dev@dpdk.org>; Tue,  7 Mar 2017 15:57:05 +0100 (CET)
In-Reply-To: <ec2824ba-6beb-7582-b238-8d66c6955e1e@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 03/07/2017 04:27 PM, Ferruh Yigit wrote:
> On 3/2/2017 4:03 PM, Andrew Rybchenko wrote:
>> Support simple queue destination flow API filters in Solarflare
>> libefx-based PMD including:
>>   - Ethernet source/destination, EtherType exact matching
>>   - VLAN ID exact matching including double-tagging
>>   - IPv4/6 source/destination and IP protocol exact matching
>>   - TCP/UDP source/destination exact matching
>>
>> Supported combinations of fields mentioned above depend on
>> firmware (including running variant) and correctly processed by
>> validate callback.
>>
>>
>> Andrew Rybchenko (2):
>>    net/sfc: implement dummy filter control callback
>>    net/sfc: provide a way to check if filter is supported
>>
>> Mark Spender (2):
>>    net/sfc/base: split local MAC I/G back into separate flags
>>    net/sfc/base: improve API to get supported filter matches
>>
>> Roman Zhukov (7):
>>    net/sfc: add flow API filters support
>>    net/sfc: add VLAN in flow API filters support
>>    net/sfc: add IPV4 in flow API filters support
>>    net/sfc: add IPV6 in flow API filters support
>>    net/sfc: add TCP in flow API filters support
>>    net/sfc: add UDP in flow API filters support
>>    net/sfc: add unknown unicast/multicast match in flow API
> Hi Andrew,
>
> Patchset looks good overall, I just did some really minor comments, can
> you please address them in next version of the patchset?

Hi Ferruh,

thanks for the review. We'll address the review notes in v2.

> Also can you please update release notes, to announce "SFC rte_flow
> support" ?

Will do. I remember about roadmap, but I'm always forgetting about 
release notes.

Thanks,
Andrew.