From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Subject: Re: [PATCH v2 1/2] net/sfc: choose datapaths after probe and before attach
Date: Fri, 31 Mar 2017 16:14:32 +0100 [thread overview]
Message-ID: <1ed6e022-b5fc-579e-3dda-84bb26713fcc@intel.com> (raw)
In-Reply-To: <1490806759-17457-1-git-send-email-arybchenko@solarflare.com>
On 3/29/2017 5:59 PM, Andrew Rybchenko wrote:
> Datapath choice requires NIC capabilities knowledge and, therefore,
> should be done after probe. Whereas NIC resources estimation needs
> to know chosen datapath (e.g. if Tx datapath is going to use TSO).
>
> Fixes: 8221da743f58 ("net/sfc: factor out libefx-based Rx datapath")
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> It could be squashed into corresponding patch, but unfortunately it
> happens with conflicts due to sa->state check removal from
> sfc_eth_dev_set_ops() where nearby lines are added after 8221da743f58.
> I think the bug is not major, so it could wait for rc1 and applied as
> fixes.
>
Applied to dpdk-next-net/master, thanks.
(Instead of squash, applied as seperata patch, fixes commit needs to be
fixed when merged into main repo)
prev parent reply other threads:[~2017-03-31 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 15:23 [PATCH 1/2] net/sfc: choose datapaths after probe and before attach Andrew Rybchenko
2017-03-29 15:23 ` [PATCH 2/2] net/sfc: do not drop TSO on device configure Andrew Rybchenko
2017-03-29 16:59 ` [PATCH v2 1/2] net/sfc: choose datapaths after probe and before attach Andrew Rybchenko
2017-03-29 16:59 ` [PATCH v2 2/2] net/sfc: do not drop TSO on device configure Andrew Rybchenko
2017-03-31 15:17 ` Ferruh Yigit
2017-03-31 15:14 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ed6e022-b5fc-579e-3dda-84bb26713fcc@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).