From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 1/2] net/sfc: choose datapaths after probe and before attach Date: Fri, 31 Mar 2017 16:14:32 +0100 Message-ID: <1ed6e022-b5fc-579e-3dda-84bb26713fcc@intel.com> References: <1490801039-4723-1-git-send-email-arybchenko@solarflare.com> <1490806759-17457-1-git-send-email-arybchenko@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Andrew Rybchenko , dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4CFD92BB4 for ; Fri, 31 Mar 2017 17:14:34 +0200 (CEST) In-Reply-To: <1490806759-17457-1-git-send-email-arybchenko@solarflare.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/29/2017 5:59 PM, Andrew Rybchenko wrote: > Datapath choice requires NIC capabilities knowledge and, therefore, > should be done after probe. Whereas NIC resources estimation needs > to know chosen datapath (e.g. if Tx datapath is going to use TSO). > > Fixes: 8221da743f58 ("net/sfc: factor out libefx-based Rx datapath") > > Signed-off-by: Andrew Rybchenko > --- > It could be squashed into corresponding patch, but unfortunately it > happens with conflicts due to sa->state check removal from > sfc_eth_dev_set_ops() where nearby lines are added after 8221da743f58. > I think the bug is not major, so it could wait for rc1 and applied as > fixes. > Applied to dpdk-next-net/master, thanks. (Instead of squash, applied as seperata patch, fixes commit needs to be fixed when merged into main repo)