From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Subject: Re: [PATCH] eal: fix rte_zalloc_socket to zero memory Date: Sun, 9 Dec 2018 20:20:25 +0100 Message-ID: <1f81a7b2-749c-e384-540c-741bf2a3162d@ericsson.com> References: <20181207222420.9508-1-dharton@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: anatoly.burakov@intel.com To: David Harton , dev@dpdk.org Return-path: Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id 6FB372C02 for ; Sun, 9 Dec 2018 20:20:29 +0100 (CET) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id EEFD44000C for ; Sun, 9 Dec 2018 20:20:28 +0100 (CET) In-Reply-To: <20181207222420.9508-1-dharton@cisco.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2018-12-07 23:24, David Harton wrote: > The zalloc and calloc functions do not actually zero the memory. > Added memset to rte_zmalloc_socket() so allocated memory is cleared. > > Signed-off-by: David Harton > --- > lib/librte_eal/common/rte_malloc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c > index 0da5ad5e8..be382e534 100644 > --- a/lib/librte_eal/common/rte_malloc.c > +++ b/lib/librte_eal/common/rte_malloc.c > @@ -74,7 +74,9 @@ rte_malloc(const char *type, size_t size, unsigned align) > void * > rte_zmalloc_socket(const char *type, size_t size, unsigned align, int socket) > { > - return rte_malloc_socket(type, size, align, socket); > + void *new_ptr = rte_malloc_socket(type, size, align, socket); > + if (new_ptr) memset(new_ptr, 0, size); Maybe it would be worth to have a likely() here. > + return new_ptr; > } > > /* >