From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH] eal: fix check when retrieving current cpu affinity Date: Thu, 14 Feb 2019 16:44:40 +0000 Message-ID: <1fed1442-efc2-0156-7db1-8b2c01292659@intel.com> References: <1550150874-9535-1-git-send-email-david.marchand@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: David Marchand , dev@dpdk.org Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 600D31B440 for ; Thu, 14 Feb 2019 17:44:42 +0100 (CET) In-Reply-To: <1550150874-9535-1-git-send-email-david.marchand@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 14-Feb-19 1:27 PM, David Marchand wrote: > pthread_getaffinity_np returns a >0 value when failing. > > This is mainly for the sake of correctness. > The only case where it could fail is when passing an incorrect cpuset > size wrt to the kernel. > > Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection") > Signed-off-by: David Marchand > --- > lib/librte_eal/common/eal_common_options.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c > index 6c96f45..1f45f82 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -1343,10 +1343,9 @@ static int xdigit2val(unsigned char c) > unsigned int lcore_id; > unsigned int removed = 0; > rte_cpuset_t affinity_set; > - pthread_t tid = pthread_self(); > > - if (pthread_getaffinity_np(tid, sizeof(rte_cpuset_t), > - &affinity_set) < 0) > + if (pthread_getaffinity_np(pthread_self(), sizeof(rte_cpuset_t), > + &affinity_set)) > CPU_ZERO(&affinity_set); > > for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { > CC: stable? -- Thanks, Anatoly