From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v4 05/15] net/dpaa2: use rte_eth_linkstatus_set Date: Tue, 16 Jan 2018 15:27:20 +0530 Message-ID: <1ffa95f4-fd66-6e6f-274b-751a18efcbb2@nxp.com> References: <20180108174514.14688-1-stephen@networkplumber.org> <20180111170658.2809-1-ferruh.yigit@intel.com> <20180111170658.2809-5-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Cc: Hemant Agrawal , Bruce Richardson , Konstantin Ananyev , To: Ferruh Yigit , Stephen Hemminger Return-path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0060.outbound.protection.outlook.com [104.47.37.60]) by dpdk.org (Postfix) with ESMTP id 87F11A495 for ; Tue, 16 Jan 2018 10:43:10 +0100 (CET) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tuesday 16 January 2018 03:14 PM, Shreyansh Jain wrote: > On Thursday 11 January 2018 10:36 PM, Ferruh Yigit wrote: >> From: Stephen Hemminger >> >> Use new helper function to update the link status. >> As a good side effect this fixes a but because this driver was not >                               ^^^^^^ >                           needs rephrasing > >> returning correct status (should be -1 in link_status changed). >> >> Signed-off-by: Stephen Hemminger >> --- >>   drivers/net/dpaa2/dpaa2_ethdev.c | 65 >> +++++----------------------------------- >>   1 file changed, 7 insertions(+), 58 deletions(-) > > Other than the change in commit message highlighted above: > > Acked-by: Shreyansh Jain > > Thanks. > Also, I forgot to add in previous email, I am assuming _rte_eth_linkstatus_get would be rte_eth_linkstatus_get eventually. I concur with your comments in [1] - it certainly would be better to have either @internal or _rte - and not both. http://dpdk.org/ml/archives/dev/2018-January/086742.html