From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Iremonger,
Bernard"
<bernard.iremonger-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [RFC PATCH 3/4] doc: nics guide
Date: Mon, 02 Feb 2015 15:33:30 +0100 [thread overview]
Message-ID: <2004705.LxAZXTX1Ao@xps13> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C2049DCC0B-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Hi Bernard,
Please try to remove useless lines when answering.
I'm digging in the message to find your comments ;)
2015-02-02 14:11, Iremonger, Bernard:
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > --- /dev/null
> > +++ b/doc/guides/nics/ixgbe.rst
> > @@ -0,0 +1,184 @@
> > +.. BSD LICENSE
> > + Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> Hi Thomas,
>
> 2014 should move to 2015
I think I should keep it as is because I'm only moving sections
and I don't have any right to change an Intel copyright.
> > --- a/doc/guides/prog_guide/index.rst
> > +++ b/doc/guides/prog_guide/index.rst
> > @@ -48,12 +48,7 @@ Programmer's Guide
> > mempool_lib
> > mbuf_lib
> > poll_mode_drv
> > - i40e_ixgbe_igb_virt_func_drv
> > - driver_vm_emul_dev
> > ivshmem_lib
> > - poll_mode_drv_emulated_virtio_nic
> > - poll_mode_drv_paravirtual_vmxnets_nic
> > - libpcap_ring_based_poll_mode_drv
> > link_bonding_poll_mode_drv_lib
> > timer_lib
> > hash_lib
> > @@ -101,18 +96,6 @@ Programmer's Guide
> >
> > :ref:`Figure 9. An mbuf with Three Segments <pg_figure_9>`
> >
> > -:ref:`Figure 10. Virtualization for a Single Port NIC in SR-IOV Mode <pg_figure_10>`
> > -
> > -:ref:`Figure 11. Performance Benchmark Setup <pg_figure_11>`
> > -
> > -:ref:`Figure 12. Fast Host-based Packet Processing <pg_figure_12>`
> > -
> > -:ref:`Figure 13. Inter-VM Communication <pg_figure_13>`
> > -
> > -:ref:`Figure 14. Host2VM Communication Example Using kni vhost Back End <pg_figure_14>`
> > -
> > -:ref:`Figure 15. Host2VM Communication Example Using qemu vhost Back End <pg_figure_15>`
> > -
> > :ref:`Figure 16. Memory Sharing inthe Intel® DPDK Multi-process Sample Application <pg_figure_16>`
> >
> > :ref:`Figure 17. Components of an Intel® DPDK KNI Application <pg_figure_17>` diff --git
>
> References to Figures 9 to 17 have been removed have they been reinstated somewhere else ?
Figures 10 to 15 moved in doc/guides/nics/img.
I didn't re-create the references in doc/guides/nics/index.rst nor renumbered
the ones in doc/guides/prog_guide/index.rst.
I think these manual numberings should be removed as it is a pain to update.
Actually I don't really understand what is the usage of such references.
So I suggest to completely remove them or generate them with a script.
Thanks
--
Thomas
next prev parent reply other threads:[~2015-02-02 14:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 23:35 [RFC PATCH 0/4] welcome doc for new nics and environments Thomas Monjalon
[not found] ` <1422747307-13792-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-01-31 23:35 ` [RFC PATCH 1/4] doc: fix file attributes Thomas Monjalon
2015-01-31 23:35 ` [RFC PATCH 2/4] doc: move Xen guide out of programmers guide Thomas Monjalon
2015-01-31 23:35 ` [RFC PATCH 3/4] doc: nics guide Thomas Monjalon
[not found] ` <1422747307-13792-4-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-02-02 14:11 ` Iremonger, Bernard
[not found] ` <8CEF83825BEC744B83065625E567D7C2049DCC0B-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-02 14:33 ` Thomas Monjalon [this message]
2015-02-02 14:59 ` Iremonger, Bernard
[not found] ` <8CEF83825BEC744B83065625E567D7C2049DCC4E-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-02 17:11 ` Thomas Monjalon
2015-02-02 17:33 ` Iremonger, Bernard
[not found] ` <8CEF83825BEC744B83065625E567D7C2049DCD83-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-02 17:38 ` Thomas Monjalon
2015-02-02 17:54 ` Iremonger, Bernard
2015-01-31 23:35 ` [RFC PATCH 4/4] doc: remove copyright footer Thomas Monjalon
2015-03-19 16:48 ` [PATCH v2 0/3] split programmers guide a bit Thomas Monjalon
[not found] ` <1426783711-2407-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-03-19 16:48 ` [PATCH v2 1/3] doc: fix file attributes Thomas Monjalon
[not found] ` <1426783711-2407-2-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-03-19 18:03 ` Butler, Siobhan A
2015-03-19 16:48 ` [PATCH v2 2/3] doc: move Xen guide out of programmers guide Thomas Monjalon
[not found] ` <1426783711-2407-3-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-03-19 18:03 ` Butler, Siobhan A
2015-03-19 16:48 ` [PATCH v2 3/3] doc: nics guide Thomas Monjalon
[not found] ` <1426783711-2407-4-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-03-19 17:36 ` Iremonger, Bernard
2015-03-19 18:02 ` Butler, Siobhan A
2015-03-30 23:38 ` [PATCH v2 0/3] split programmers guide a bit Thomas Monjalon
2015-03-31 11:34 ` Mcnamara, John
[not found] ` <B27915DBBA3421428155699D51E4CFE2F001CD-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-31 12:23 ` Thomas Monjalon
2015-04-01 9:19 ` Iremonger, Bernard
[not found] ` <8CEF83825BEC744B83065625E567D7C204A0B91F-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-04-01 16:36 ` Mcnamara, John
[not found] ` <B27915DBBA3421428155699D51E4CFE2F01048-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-04-01 17:20 ` Iremonger, Bernard
[not found] ` <8CEF83825BEC744B83065625E567D7C204A0BAB5-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-04-02 7:59 ` Mcnamara, John
2015-04-02 11:04 ` [RFC] doc: refactored figure numbers into references John McNamara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2004705.LxAZXTX1Ao@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=bernard.iremonger-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).