From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [RFC PATCH 3/4] doc: nics guide
Date: Mon, 02 Feb 2015 15:33:30 +0100
Message-ID: <2004705.LxAZXTX1Ao@xps13>
References: <1422747307-13792-1-git-send-email-thomas.monjalon@6wind.com>
 <1422747307-13792-4-git-send-email-thomas.monjalon@6wind.com>
 <8CEF83825BEC744B83065625E567D7C2049DCC0B@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Iremonger, Bernard" <bernard.iremonger-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <8CEF83825BEC744B83065625E567D7C2049DCC0B-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Bernard,

Please try to remove useless lines when answering.
I'm digging in the message to find your comments ;)

2015-02-02 14:11, Iremonger, Bernard:
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > --- /dev/null
> > +++ b/doc/guides/nics/ixgbe.rst
> > @@ -0,0 +1,184 @@
> > +..  BSD LICENSE
> > +    Copyright(c) 2010-2014 Intel Corporation. All rights reserved.=

> Hi Thomas,
>=20
> 2014  should move to 2015

I think I should keep it as is because I'm only moving sections
and I don't have any right to change an Intel copyright.

> > --- a/doc/guides/prog_guide/index.rst
> > +++ b/doc/guides/prog_guide/index.rst
> > @@ -48,12 +48,7 @@ Programmer's Guide
> >      mempool_lib
> >      mbuf_lib
> >      poll_mode_drv
> > -    i40e_ixgbe_igb_virt_func_drv
> > -    driver_vm_emul_dev
> >      ivshmem_lib
> > -    poll_mode_drv_emulated_virtio_nic
> > -    poll_mode_drv_paravirtual_vmxnets_nic
> > -    libpcap_ring_based_poll_mode_drv
> >      link_bonding_poll_mode_drv_lib
> >      timer_lib
> >      hash_lib
> > @@ -101,18 +96,6 @@ Programmer's Guide
> >=20
> >  :ref:`Figure 9. An mbuf with Three Segments <pg_figure_9>`
> >=20
> > -:ref:`Figure 10. Virtualization for a Single Port NIC in SR-IOV Mo=
de <pg_figure_10>`
> > -
> > -:ref:`Figure 11. Performance Benchmark Setup <pg_figure_11>`
> > -
> > -:ref:`Figure 12. Fast Host-based Packet Processing <pg_figure_12>`=

> > -
> > -:ref:`Figure 13. Inter-VM Communication <pg_figure_13>`
> > -
> > -:ref:`Figure 14. Host2VM Communication Example Using kni vhost Bac=
k End <pg_figure_14>`
> > -
> > -:ref:`Figure 15. Host2VM Communication Example Using qemu vhost Ba=
ck End <pg_figure_15>`
> > -
> >  :ref:`Figure 16. Memory Sharing inthe Intel=AE DPDK Multi-process =
Sample Application <pg_figure_16>`
> >=20
> >  :ref:`Figure 17. Components of an Intel=AE DPDK KNI Application <p=
g_figure_17>` diff --git
>=20
> References to Figures 9 to 17 have been removed have they been reinst=
ated somewhere else ?

Figures 10 to 15 moved in doc/guides/nics/img.

I didn't re-create the references in doc/guides/nics/index.rst nor renu=
mbered
the ones in doc/guides/prog_guide/index.rst.
I think these manual numberings should be removed as it is a pain to up=
date.
Actually I don't really understand what is the usage of such references=
.
So I suggest to completely remove them or generate them with a script.

Thanks
--=20
Thomas