From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [RFC 1/2] vhost: add packed ring support to vring
 base requests
Date: Tue, 14 Aug 2018 14:09:21 +0200
Message-ID: <2004c11d-6c2a-bed5-389d-bd92fee25ed1@redhat.com>
References: <20180808152323.9660-1-maxime.coquelin@redhat.com>
 <20180808152323.9660-2-maxime.coquelin@redhat.com>
 <20180810070902.we3jf4xfpbgu5vst@jenstp.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com
To: Jens Freimann <jfreiman@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id B08D94C99
 for <dev@dpdk.org>; Tue, 14 Aug 2018 14:09:26 +0200 (CEST)
In-Reply-To: <20180810070902.we3jf4xfpbgu5vst@jenstp.localdomain>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Jens,

On 08/10/2018 09:09 AM, Jens Freimann wrote:
> On Wed, Aug 08, 2018 at 05:23:22PM +0200, Maxime Coquelin wrote:
>> For consistency with Vhost kernel backend, save the wrap
>> counter value into bit 31 of num's vring state field.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> lib/librte_vhost/vhost_user.c | 16 ++++++++++++----
>> 1 file changed, 12 insertions(+), 4 deletions(-)
>>
>> diff --git a/lib/librte_vhost/vhost_user.c 
>> b/lib/librte_vhost/vhost_user.c
>> index a2d4c9ffc..31cfdf163 100644
>> --- a/lib/librte_vhost/vhost_user.c
>> +++ b/lib/librte_vhost/vhost_user.c
>> @@ -648,10 +648,15 @@ static int
>> vhost_user_set_vring_base(struct virtio_net *dev,
>>               VhostUserMsg *msg)
>> {
>> -    dev->virtqueue[msg->payload.state.index]->last_used_idx  =
>> -            msg->payload.state.num;
>> -    dev->virtqueue[msg->payload.state.index]->last_avail_idx =
>> -            msg->payload.state.num;
>> +    struct vhost_virtqueue *vq = 
>> dev->virtqueue[msg->payload.state.index];
>> +    if (dev->features & (1ULL << VIRTIO_F_RING_PACKED)) {
>> +        vq->avail_wrap_counter = msg->payload.state.num >> 31;
>> +        vq->used_wrap_counter = vq->avail_wrap_counter;
> 
> Maybe I don't understand when this is called, but the wrap counters
> could have different values, no?

No, because we set the used index to the saved avail index value, so
wrap counters must be the same.

> Apart from that:
> 
> Reviewed-by: Jens Freimann <jfreimann@redhat.com>
> regards,
> Jens