From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] igb_uio: fix compile error
Date: Mon, 16 Oct 2017 12:59:00 +0200
Message-ID: <2009183.piveRrLndW@xps>
References: <1508119093-42500-1-git-send-email-jingjing.wu@intel.com>
 <ED26CBA2FAD1BF48A8719AEF02201E3651315B8E@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C64671B668
 for <dev@dpdk.org>; Mon, 16 Oct 2017 12:59:02 +0200 (CEST)
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E3651315B8E@SHSMSX103.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

16/10/2017 12:10, Tan, Jianfeng:
> From: Wu, Jingjing
> > 
> > Compile fails when kernel version is <= 3.17 with error:
> > "dereferencing pointer to incomplete type". This is because struct
> > uio_device definition is not exposed in kernel earlier than 3.17.
> > 
> > This patch fixes it by using pointer of rte_uio_pci_dev as
> > dev_id instead of uio_device for irq device handler.
> > 
> > Fixes: 5f6ff30dc507 ("igb_uio: fix interrupt enablement after FLR in VM")
> > 
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> 
> 
> Yes, we don't have to use struct uio_device as the cookie; what we need is struct uio_info for notification.
> 
> Reviewed-by: Jianfeng Tan <jianfeng.tan@intel.com>

Applied, thanks