From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/4] meter: add meter configuration profile api Date: Thu, 12 Oct 2017 22:51:05 +0200 Message-ID: <2009950.PBKcGuERrl@xps> References: <1503488186-90047-1-git-send-email-cristian.dumitrescu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Cristian Dumitrescu Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id D1C4B1B3B7 for ; Thu, 12 Oct 2017 22:51:07 +0200 (CEST) In-Reply-To: <1503488186-90047-1-git-send-email-cristian.dumitrescu@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Cristian Dumitrescu (4): > meter: add meter configuration profile > test: meter autotest update > qos_meter: accommodate meter api changes > deprecation: removed the librte_meter notice > > doc/guides/rel_notes/deprecation.rst | 3 - > examples/qos_meter/main.c | 36 ++++--- > examples/qos_meter/main.h | 32 ++++--- > lib/librte_meter/rte_meter.c | 88 ++++++++++------- > lib/librte_meter/rte_meter.h | 170 ++++++++++++++++++++++----------- > lib/librte_meter/rte_meter_version.map | 8 ++ > test/test/test_meter.c | 138 ++++++++++++++++---------- > 7 files changed, 306 insertions(+), 169 deletions(-) There are too many checkpatches warnings. And there is at least one compilation error with the first patch: test/test/test_meter.c:93:34: fatal error: incompatible pointer types passing 'struct rte_meter_srtcm_params *' to parameter of type 'struct rte_meter_srtcm_profile *' [-Wincompatible-pointer-types] Please try to improve for RC2.