From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 3/3] vfio: use the generic multi-process channel Date: Thu, 25 Jan 2018 11:47:20 +0100 Message-ID: <2010166.0Q39LqRaO8@xps> References: <1512067450-59203-1-git-send-email-jianfeng.tan@intel.com> <1516853783-108023-1-git-send-email-jianfeng.tan@intel.com> <1516853783-108023-4-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, anatoly.burakov@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com To: Jianfeng Tan Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 6BFA31E35 for ; Thu, 25 Jan 2018 11:48:03 +0100 (CET) In-Reply-To: <1516853783-108023-4-git-send-email-jianfeng.tan@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/01/2018 05:16, Jianfeng Tan: > Previously, vfio uses its own private channel for the secondary > process to get container fd and group fd from the primary process. > > This patch changes to use the generic mp channel. There was a private request to get it in 18.02-rc2. I have 3 concerns: 1/ It is late 2/ It is not yet reviewed by Anatoly and Konstantin 3/ We try to not rework the existing code in RC2, because it would totally invalidate the validation work done for RC1.