From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] examples/service_cores: check lcores before test run Date: Mon, 29 Oct 2018 03:06:27 +0100 Message-ID: <2011444.UUVssWKW1k@xps> References: <20181012131403.36566-1-vipin.varghese@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Van Haaren, Harry" , "Byrne, Stephen1" To: "Varghese, Vipin" Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 804D1160 for ; Mon, 29 Oct 2018 03:06:22 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/10/2018 16:57, Van Haaren, Harry: > From: Varghese, Vipin > > > > The service core samples has varied profiles created to run on specified > > lcore count. The patch adds the check before each run, to ensure > > example has sufficent lcores to be added as service cores on given run > > profile. If sufficent cores are not found, the run is skipped with user > > notification. > > > > Signed-off-by: Vipin Varghese > > --- > > The +1 feels weird, but given there's a core offset of 1 above, > this seems like the best solution: > > Acked-by: Harry van Haaren Applied, thanks