From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] app: fix refcnt in mbuf allocation Date: Mon, 6 May 2013 15:56:16 +0200 Message-ID: <20130506135616.GN12221@6wind.com> References: <1367844470-15346-1-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dev-VfR2kkLFssw@public.gmane.org Return-path: Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi all (replying below) On Mon, May 06, 2013 at 09:28:33AM -0400, Han, Dongsu wrote: > Sounds good. With the two bug fixes I submitted txonly now runs perfectly. > Thanks! > -Dongsu > On May 6, 2013 8:47 AM, "Thomas Monjalon" wrote: > > > Hi Dongsu Han, > > > > I think your fix is right. > > I've just removed tx_mbuf_alloc() and directly called rte_pktmbuf_alloc() > > instead. > > Is it OK for you ? > > Could you also review this (modified) description ? [...] While using rte_pktmbuf_alloc() is the correct fix, it's much slower than __rte_mbuf_raw_alloc() due to the unnecessary call to rte_pktmbuf_reset(). Since testpmd is often used for performance testing, we should consider a wrapper function calling __rte_mbuf_raw_alloc() directly instead, as in rte_rxmbuf_alloc() implemented in igb and ixgbe PMDs. -- Adrien Mazarguil 6WIND