From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] Add support for 82599 Tx->Rx loopback operation. Date: Wed, 25 Sep 2013 16:47:26 +0200 Message-ID: <201309251647.26757.thomas.monjalon@6wind.com> References: <1379963780-5044-1-git-send-email-jigsaw@gmail.com> <1FD9B82B8BF2CF418D9A1000154491D973F50C7E@ORSMSX102.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: jigsaw Return-path: In-Reply-To: <1FD9B82B8BF2CF418D9A1000154491D973F50C7E-P5GAC/sN6hlcIJlls4ac1rfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 25/09/2013 16:12, Venkatesan, Venky : > I for one would prefer that the changes not really modify any files in the > librte_pmd_ixgbe/ixgbe directory. Those files are derived directly from > the BSD driver baseline, and any changes will make future merges of newer > code more challenging. The changes should be limited to files in the > librte_pmd_ixgbe directory (and ethdev). I agree with Venky. The poll-mode drivers e1000 and ixgbe are based on drivers located in subdirectories e1000/ and ixgbe/. And by design, these poll-mode drivers use the base drivers without modifying it. So please try to restrict your changes to ixgbe_ethdev.c and ixgbe_rxtx.c. The coding rules are not written. If needed, we could add a file for it. Thanks for your patch -- Thomas