From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [memnic PATCH] pmd: use memory barrier function
	instead of asm volatile
Date: Tue, 4 Feb 2014 14:08:15 +0100
Message-ID: <201402041408.15739.thomas.monjalon@6wind.com>
References: <1390579157-23890-1-git-send-email-olivier.matz@6wind.com>
 <7F861DC0615E0C47A872E6F3C5FCDDBD0102D11D@BPXM14GP.gisp.nec.co.jp>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD0102D11D-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

30/01/2014 12:42, Hiroshi Shimamoto:
> > Use the DPDK specific function rte_mb() instead of
> > the GCC statement asm volatile ("" ::: "memory").
> >
> > Signed-off-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> 
> Yes, that's preferred for DPDK, I think.
> Looks okay to me.

Applied, thanks.

-- 
Thomas