Re: [PATCH 03/16] pkg: add recipe for RPM

[Chris Wright <chrisw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

* Thomas Monjalon (thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org) wrote:
> Packages can be built with:
> 	RPM_BUILD_NCPUS=8 rpmbuild -ta dpdk-1.5.2r2.tar.gz
> 
> There are packages for runtime, static libraries and development.
> Once devel package installed, it can be used like this:
> 	make -C /usr/share/dpdk/examples/helloworld RTE_SDK=/usr/share/dpdk
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> ---
>  pkg/rpm.spec |  143 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

This should be dpdk.spec

>  1 file changed, 143 insertions(+)
>  create mode 100644 pkg/rpm.spec
> 
> diff --git a/pkg/rpm.spec b/pkg/rpm.spec
> new file mode 100644
> index 0000000..d806d55
> --- /dev/null
> +++ b/pkg/rpm.spec
> @@ -0,0 +1,143 @@
> +Name: dpdk
> +Version: 1.5.2r1
> +Release: 1

Just wanted to be sure the NVR properly increases.  I verified using
"rpmdev-vercmp" and it looks fine.

> +Packager: packaging-pdR9zngts4EAvxtiuMwx3w@public.gmane.org
> +URL: http://dpdk.org
> +Source: http://dpdk.org/browse/dpdk/snapshot/dpdk-%{version}.tar.gz
> +
> +Summary: Intel(r) Data Plane Development Kit
> +Group: System Environment/Libraries
> +License: BSD and LGPLv2 and GPLv2
> +
> +ExclusiveArch: i686, x86_64
> +%define target %{_arch}-default-linuxapp-gcc

What is this for?

> +%define machine default
> +
> +BuildRequires: kernel-devel, kernel-headers, doxygen
> +
> +%description
> +Dummy main package. Make only subpackages.

I think the core package should have the .so, the -devel package w/
headers, and no -static package.  Including a .a file is discouraged in
Fedora:

https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries

because if you need to update the archive, e.g. for a security fix,
applications linked w/ the static library will not get fixed w/out a
rebuild.

> +%package core-runtime

perhaps just 'runtime'

> +Summary: Intel(r) Data Plane Development Kit core for runtime
> +%description core-runtime
> +Intel(r) DPDK runtime includes kernel modules, core libraries and tools.
> +testpmd application allows to test fast packet processing environments
> +on x86 platforms. For instance, it can be used to check that environment
> +can support fast path applications such as 6WINDGate, pktgen, rumptcpip, etc.
> +More libraries are available as extensions in other packages.
> +
> +%package core-static
> +Requires: %{name}-core-runtime
> +Summary: Intel(r) Data Plane Development Kit core as static libraries
> +%description core-static
> +Intel(r) DPDK static provides static version of the core libraries
> +for fast packet processing on x86 platforms.
> +More libraries are available as extensions in other packages.

We drop this

> +%package core-devel

name this devel

> +Requires: %{name}-core-static
> +Summary: Intel(r) Data Plane Development Kit core for development
> +%description core-devel
> +Intel(r) DPDK devel is a set of makefiles, headers, examples and documentation
> +for fast packet processing on x86 platforms.
> +More libraries are available as extensions in other packages.

Often it's just headers, but makefile, examples, etc are quite useful
for showing how to develop a dpdk app

> +# debuginfo packaging is broken
> +%define debug_package %{nil}

Can you add a better comment why it's broken?

> +%define destdir %{buildroot}%{_prefix}
> +%define moddir  /lib/modules/%(uname -r)/extra
> +%define datadir %{_datadir}/%{name}
> +%define docdir  %{_docdir}/%{name}
> +
> +%prep
> +%setup -q
> +
> +%build
> +make O=%{target} T=%{target} config

Did you try to update the build system to output into $RPM_BUILD_ROOT
directly?  It's much preferred compared to the cp/rmdir below

> +sed -ri 's,(RTE_MACHINE=).*,\1%{machine},' %{target}/.config
> +sed -ri 's,(RTE_APP_TEST=).*,\1n,'         %{target}/.config
> +sed -ri 's,(RTE_BUILD_SHARED_LIB=).*,\1y,' %{target}/.config
> +make O=%{target} %{?_smp_mflags}
> +cp %{target}/lib/*.so %{target}
> +sed -ri 's,(RTE_BUILD_SHARED_LIB=).*,\1n,' %{target}/.config
> +make O=%{target} %{?_smp_mflags}
> +make O=%{target} doc
> +
> +%install
> +rm -rf %{buildroot}
> +make           O=%{target}     DESTDIR=%{destdir}

Why make again (IOW, why not in %build section)?

> +mkdir -p                               %{buildroot}%{moddir}
> +mv    %{destdir}/%{target}/kmod/*.ko   %{buildroot}%{moddir}

Normally I'd use install command (-d will create directories)

> +rmdir %{destdir}/%{target}/kmod
> +mkdir -p                               %{buildroot}%{_sbindir}
> +ln -s %{datadir}/tools/igb_uio_bind.py %{buildroot}%{_sbindir}/igb_uio_bind
> +mkdir -p                               %{buildroot}%{_bindir}
> +mv    %{destdir}/%{target}/app/testpmd %{buildroot}%{_bindir}
> +rmdir %{destdir}/%{target}/app
> +mv    %{destdir}/%{target}/include     %{buildroot}%{_includedir}
> +mv    %{destdir}/%{target}/lib         %{buildroot}%{_libdir}
> +mv    %{destdir}/%{target}/*.so        %{buildroot}%{_libdir}
> +mkdir -p                               %{buildroot}%{docdir}
> +mv    %{destdir}/%{target}/doc/*       %{buildroot}%{docdir}
> +rmdir %{destdir}/%{target}/doc
> +mkdir -p                               %{buildroot}%{datadir}
> +mv    %{destdir}/%{target}/.config     %{buildroot}%{datadir}/config
> +mv    %{destdir}/%{target}             %{buildroot}%{datadir}
> +mv    %{destdir}/mk                    %{buildroot}%{datadir}
> +cp -a            examples              %{buildroot}%{datadir}
> +cp -a            tools                 %{buildroot}%{datadir}
> +ln -s            %{datadir}/config     %{buildroot}%{datadir}/%{target}/.config
> +ln -s            %{_includedir}        %{buildroot}%{datadir}/%{target}/include
> +ln -s            %{_libdir}            %{buildroot}%{datadir}/%{target}/lib
> +
> +%files core-runtime
> +%dir %{datadir}
> +%{datadir}/config
> +%{datadir}/tools
> +%{moddir}/*
> +%{_sbindir}/*
> +%{_bindir}/*
> +%{_libdir}/*.so
> +
> +%files core-static
> +%{_libdir}/*.a
> +
> +%files core-devel
> +%{_includedir}/*
> +%{datadir}/mk
> +%{datadir}/%{target}
> +%{datadir}/examples
> +%doc %{docdir}