From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Subject: Re: [PATCH] pcap: remove test for PCAP_CAN_SEND
Date: Sat, 29 Mar 2014 09:00:27 -0400
Message-ID: <20140329130027.GA13408@hmsreliant.think-freely.org>
References: <1396056749-11738-1-git-send-email-nhorman@tuxdriver.com>
 <3857255.iofc7hnFnA@x220>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <3857255.iofc7hnFnA@x220>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Sat, Mar 29, 2014 at 11:34:46AM +0100, Thomas Monjalon wrote:
> Hi Neil,
> 
> 28/03/2014 21:32, Neil Horman :
> > The libpcap library has had the ability to send packets since 2004, theres
> > really no need to test for it.  Especially in the way dpdk is doing as, as
> > according to the libpcap git tree pcap_sendpacket has never been a #define,
> > and dpdk tests for its existance with an #ifdef.  Its easier just to remove
> > the test entirely
> > 
> > Signed-off-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
> 
> A similar patch is already applied on HEAD:
> 	http://dpdk.org/browse/dpdk/commit/?id=2a315d698510e7b33
> 
My bad, thanks!
Neil

> -- 
> Thomas
>