From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH 01/15] makefiles: Fixed -share command line option error Date: Wed, 16 Apr 2014 07:00:18 -0400 Message-ID: <20140416110018.GB26829@hmsreliant.think-freely.org> References: <1397585169-14537-1-git-send-email-nhorman@tuxdriver.com> <1397585169-14537-2-git-send-email-nhorman@tuxdriver.com> <4354806.0Vn32RcRuD@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: Content-Disposition: inline In-Reply-To: <4354806.0Vn32RcRuD@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Wed, Apr 16, 2014 at 11:22:35AM +0200, Thomas Monjalon wrote: > Hi, > > 2014-04-15 14:05, Neil Horman: > > The shared libraries built with the current makefile set produce static > > libraries rather than actual shared objects. This is due to several missing > > options that are required to correctly build shared objects using ld, as > > well as a mis-specified -share option (which should be -shared). Switching > > to the use of CC rather than LD and fixing the -shared option corrects > > these problems and builds the DSOs correctly. > > > > Signed-off-by: Neil Horman > > Thanks for fixing -shared option. > > Regarding switch to CC linking, please have a look at LINK_USING_CC option. > Maybe you should use it for rte.lib.mk and rte.sharelib.mk. > Yeah, I can do that. Would you like the whole series reposted, or just the specific patch? Neil > -- > Thomas >