From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH 02/15] make: include whole archive on static link Date: Wed, 16 Apr 2014 09:33:42 -0400 Message-ID: <20140416133342.GD11887@localhost.localdomain> References: <1397585169-14537-1-git-send-email-nhorman@tuxdriver.com> <6240253.CLYuMHWmd2@xps13> <20140416110204.GC26829@hmsreliant.think-freely.org> <1915373.2zxdALVbPM@xps13> <20140416130204.GB11887@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: Content-Disposition: inline In-Reply-To: <20140416130204.GB11887-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Wed, Apr 16, 2014 at 09:02:04AM -0400, Neil Horman wrote: > On Wed, Apr 16, 2014 at 01:40:19PM +0200, Thomas Monjalon wrote: > > 2014-04-16 07:02, Neil Horman: > > > On Wed, Apr 16, 2014 at 11:26:48AM +0200, Thomas Monjalon wrote: > > > > 2014-04-15 14:05, Neil Horman: > > > > > This happens automatically on dyanmic linking, but when linking an > > > > > archive > > > > > we need to to include the whole archive to make sure we call all the > > > > > constructors. Not doing this causes them to be discarded due to the fact > > > > > theres no symbolic reference connecting the pmds to the application. > > > > > > > > > > Signed-off-by: Neil Horman > > > > > > > > This patch conflicts with Olivier's one: > > > > http://dpdk.org/browse/dpdk/commit/?id=20afd76a504155e947 > > > > > > How does it conflict? I've got it in my dpdk tree here, based off commit > > > 396b69e56a3462ff80537deccebcdecb2771d8ca, which includes Oliviers patch, and > > > mine is applied on top of it cleanly. > > > > It's not a git conflict. > > I mean --whole-archive is set twice. > > Maybe that your patch is not needed. > > > Yeah, I think you're right, its can probably just be dropped. Let me test quick > and I'll confirm > Neil > Confirmed, its redundant. You can just drop this one patch. Thanks Neil > > -- > > Thomas > > >