From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Subject: Re: [PATCH 5/5] add FILE arguement to debug functions
Date: Mon, 5 May 2014 18:55:31 -0700
Message-ID: <20140505185531.4dbd94d4@nehalam.linuxnetplumber.net>
References: <20140502234251.707598579@vyatta.com>
 <20140502234407.841791092@vyatta.com>
 <20140504122053.GA5012@localhost.localdomain>
 <20140504131750.45409335@nehalam.linuxnetplumber.net>
 <20140505105309.GD16114@hmsreliant.think-freely.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <20140505105309.GD16114-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Mon, 5 May 2014 06:53:09 -0400
Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org> wrote:

> On Sun, May 04, 2014 at 01:17:50PM -0700, Stephen Hemminger wrote:
> > On Sun, 4 May 2014 08:20:54 -0400
> > Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org> wrote:
> > 
> > > On Fri, May 02, 2014 at 04:42:56PM -0700, Stephen Hemminger wrote:
> > > > The DPDK dump functions are useful for remote debugging of an
> > > > applications. But when application runs as a daemon, stdout
> > > > is typically routed to /dev/null.
> > > > 
> > > > Instead change all these functions to take a stdio FILE * handle
> > > > instead. An application can then use open_memstream() to capture
> > > > the output.
> > > > 
> > > > Signed-off-by: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
> > > > 
> > > Why not convert these to rte_log calls?  Seems like we already have the
> > > infrastrucutre here, we just need to use it.
> > > Neil
> > > 
> > 
> > Because it is useful to have remote console like functionatlity,
> > and dumping this to log doesn't work for that.
> > 
> Why not?  Looking at it it seems to me that you could get this exact same
> functionality by calling rte_openlog_stream(stdout);
> 
> Neil
> 

If you have a remote console (per connection) and a thread handling
those requests you want to direct output of a command like 'show mempool'
to respond to that request. An existing file descriptor don't work they are global
no per thread. There is a difference between log and response to request.