From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Subject: Re: [PATCH v2 09/10] igbuio: show irq mode in sysfs
Date: Sun, 8 Jun 2014 11:37:04 -0400
Message-ID: <20140608153704.GA27652@localhost.localdomain>
References: <20140606235028.189345212@networkplumber.org>
 <20140606235115.248804518@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <20140606235115.248804518-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Fri, Jun 06, 2014 at 04:50:37PM -0700, Stephen Hemminger wrote:
> Since irq mode is determined dynamically on a per-device
> basis, and virtio needs to know if using intx or msi-x,
> make it a sysfs attribute.
> 
> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> @@ -43,6 +43,10 @@
>  	IGBUIO_MSIX_INTR_MODE
>  };
>  
> +static const char *igbuio_intr_modes[] = {
> +	"legacy", "msi", "msix"
> +};
> +
>  /**
>   * A structure describing the private information for a uio device.
>   */
> @@ -128,8 +132,20 @@
>  }
>  
>  static DEVICE_ATTR(max_vfs, S_IRUGO | S_IWUSR, show_max_vfs, store_max_vfs);
> +
> +static ssize_t irq_mode_show(struct device *dev,
> +			     struct device_attribute *attr, char *buf)
> +{
> +	struct uio_info *info = pci_get_drvdata(to_pci_dev(dev));
> +	struct rte_uio_pci_dev *udev = igbuio_get_uio_pci_dev(info);
> +
> +	return sprintf(buf, "%s\n", igbuio_intr_modes[udev->mode]);
> +}
> +static DEVICE_ATTR(irq_mode, S_IRUGO, irq_mode_show, NULL);
> +
>  static struct attribute *dev_attrs[] = {
>  	&dev_attr_max_vfs.attr,
> +	&dev_attr_irq_mode.attr,
>  	NULL,
>  };
>  
> 
> 
Do you really need this attribute?  The pci bus sysfs tree already exports irq
mode information for each device allocated already in
/sys/bus/pci/device/msi_irqs<irq_number>

Neil