* [PATCH 2/2] virtio: fix build with debug enabled [not found] ` <20140612183045.19dfa1ef-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org> @ 2014-06-13 1:32 ` Stephen Hemminger [not found] ` <20140612183250.106f8d87-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Stephen Hemminger @ 2014-06-13 1:32 UTC (permalink / raw) To: Stephen Hemminger; +Cc: dev-VfR2kkLFssw Remove useless message that breaks if VIRTIO_DEBUG_DRIVER is defined. virtio_ethdev.c:224:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] Signed-off-by: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org> --- a/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-10 15:30:23.440093214 -0700 +++ b/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-10 15:30:23.436093187 -0700 @@ -213,8 +213,6 @@ virtio_set_multiple_queues(struct rte_et ctrl.hdr.cmd = VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET; memcpy(ctrl.data, &nb_queues, sizeof(uint16_t)); - PMD_INIT_LOG(DEBUG, "ctrl.data=%d\n", *(int *)ctrl.data); - dlen[0] = sizeof(uint16_t); ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1); ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20140612183250.106f8d87-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>]
* Re: [PATCH 2/2] virtio: fix build with debug enabled [not found] ` <20140612183250.106f8d87-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org> @ 2014-06-13 1:54 ` Ouyang, Changchun 2014-06-13 9:23 ` Thomas Monjalon 1 sibling, 0 replies; 3+ messages in thread From: Ouyang, Changchun @ 2014-06-13 1:54 UTC (permalink / raw) To: Stephen Hemminger; +Cc: dev-VfR2kkLFssw@public.gmane.org Acked by Changchun Ouyang -----Original Message----- From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Stephen Hemminger Sent: Friday, June 13, 2014 9:33 AM To: Stephen Hemminger Cc: dev-VfR2kkLFssw@public.gmane.org Subject: [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled Remove useless message that breaks if VIRTIO_DEBUG_DRIVER is defined. virtio_ethdev.c:224:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] Signed-off-by: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org> --- a/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-10 15:30:23.440093214 -0700 +++ b/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-10 15:30:23.436093187 -0700 @@ -213,8 +213,6 @@ virtio_set_multiple_queues(struct rte_et ctrl.hdr.cmd = VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET; memcpy(ctrl.data, &nb_queues, sizeof(uint16_t)); - PMD_INIT_LOG(DEBUG, "ctrl.data=%d\n", *(int *)ctrl.data); - dlen[0] = sizeof(uint16_t); ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1); ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] virtio: fix build with debug enabled [not found] ` <20140612183250.106f8d87-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org> 2014-06-13 1:54 ` Ouyang, Changchun @ 2014-06-13 9:23 ` Thomas Monjalon 1 sibling, 0 replies; 3+ messages in thread From: Thomas Monjalon @ 2014-06-13 9:23 UTC (permalink / raw) To: Stephen Hemminger; +Cc: dev-VfR2kkLFssw 2014-06-12 18:32, Stephen Hemminger: > Remove useless message that breaks if VIRTIO_DEBUG_DRIVER is defined. > virtio_ethdev.c:224:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] > > Signed-off-by: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org> Acked-by: Changchun Ouyang <changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Applied for version 1.7.0. Thanks -- Thomas ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-13 9:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140612183045.19dfa1ef@nehalam.linuxnetplumber.net>
[not found] ` <20140612183045.19dfa1ef-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2014-06-13 1:32 ` [PATCH 2/2] virtio: fix build with debug enabled Stephen Hemminger
[not found] ` <20140612183250.106f8d87-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2014-06-13 1:54 ` Ouyang, Changchun
2014-06-13 9:23 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).