From: Chris Wright <chrisw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Richardson,
Bruce" <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Stephen Hemminger
<stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: [PATCH] igb_uio: cap max VFs at 7 to reserve one for PF
Date: Fri, 13 Jun 2014 10:51:37 -0700 [thread overview]
Message-ID: <20140613175137.GS1384@x220.localdomain> (raw)
In-Reply-To: <20140613102440.19537123-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
To keep from confusing users, cap max VFs at 7, despite PCI SR-IOV config
space showing a max of 8. This reserves a queue pair for the PF.
This issue was cited here:
http://dpdk.org/ml/archives/dev/2014-April/001832.html
Cc: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Signed-off-by: Chris Wright <chrisw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
This is what Linux kernel driver does. I have only
compile tested it. Stephen sending to you and Bruce
in case you want to Ack and add to your current queue.
lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
index 6fa7396..d5db97a 100644
--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
@@ -139,6 +139,12 @@ store_max_vfs(struct device *dev, struct device_attribute *attr,
if (0 != strict_strtoul(buf, 0, &max_vfs))
return -EINVAL;
+ /* reserve a queue pair for PF */
+ if (max_vfs > 7) {
+ dev_warn(dev, "Maxixum of 7 VFs per PF, using max\n");
+ max_vfs = 7;
+ }
+
if (0 == max_vfs)
pci_disable_sriov(pdev);
else if (0 == local_pci_num_vf(pdev))
next prev parent reply other threads:[~2014-06-13 17:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 23:50 [PATCH v2 00/10] igb_uio patches Stephen Hemminger
2014-06-06 23:50 ` [PATCH v2 01/10] igb_uio: use kernel standard log message Stephen Hemminger
2014-06-06 23:50 ` [PATCH v2 02/10] igb_uio: use standard uio naming Stephen Hemminger
2014-06-06 23:50 ` [PATCH v2 03/10] igb_uio: fix checkpatch warnings Stephen Hemminger
2014-06-06 23:50 ` [PATCH v2 04/10] igb_uio: dont wrap pci_num_vf function needlessly Stephen Hemminger
2014-06-06 23:50 ` [PATCH v2 05/10] Subjec: igb_uio: msix cleanups Stephen Hemminger
[not found] ` <20140606235108.480879979-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2014-07-18 11:05 ` Thomas Monjalon
2014-06-06 23:50 ` [PATCH v2 06/10] igb_uio: propogate error numbers in probe code Stephen Hemminger
2014-06-06 23:50 ` [PATCH v2 07/10] igb_uio: make irq mode param read-only Stephen Hemminger
2014-06-06 23:50 ` [PATCH v2 08/10] igb_uio: fix IRQ mode handling Stephen Hemminger
[not found] ` <20140606235113.600528535-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2014-07-18 11:49 ` Thomas Monjalon
2014-07-18 12:41 ` Thomas Monjalon
2014-06-06 23:50 ` [PATCH v2 09/10] igbuio: show irq mode in sysfs Stephen Hemminger
[not found] ` <20140606235115.248804518-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2014-06-08 15:37 ` Neil Horman
[not found] ` <20140608153704.GA27652-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-06-11 18:27 ` Carew, Alan
[not found] ` <0E29434AEE0C3A4180987AB476A6F630593A63AB-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-11 20:08 ` Stephen Hemminger
[not found] ` <20140611130808.3342aad0-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2014-06-16 8:03 ` Carew, Alan
2014-06-13 0:28 ` Neil Horman
2014-06-06 23:50 ` [PATCH v2 10/10] igbuio: use mode string for module param Stephen Hemminger
[not found] ` <20140606235028.189345212-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2014-06-13 16:14 ` [PATCH v2 00/10] igb_uio patches Thomas Monjalon
2014-06-13 17:24 ` Stephen Hemminger
[not found] ` <20140613102440.19537123-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2014-06-13 17:51 ` Chris Wright [this message]
[not found] ` <20140613175137.GS1384-SwUeJysX96B82hYKe6nXyg@public.gmane.org>
2014-06-13 18:02 ` [PATCH] igb_uio: cap max VFs at 7 to reserve one for PF Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B01AA36117-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-13 18:14 ` Chris Wright
[not found] ` <20140613181403.GT1384-SwUeJysX96B82hYKe6nXyg@public.gmane.org>
2014-06-13 19:22 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B01AA3616B-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-13 19:48 ` Chris Wright
2014-06-16 14:13 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140613175137.GS1384@x220.localdomain \
--to=chrisw-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox