From mboxrd@z Thu Jan 1 00:00:00 1970 From: Flavio Leitner Subject: Re: [PATCH] net: get rid of SET_ETHTOOL_OPS Date: Wed, 2 Jul 2014 10:07:23 -0300 Message-ID: <20140702130723.GU5631@t520.home> References: <1404238780-19596-1-git-send-email-fbl@redhat.com> <5006516.KlozUPNl4J@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: Content-Disposition: inline In-Reply-To: <5006516.KlozUPNl4J@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Wed, Jul 02, 2014 at 11:48:51AM +0200, Thomas Monjalon wrote: > Hi Flavio, > > 2014-07-01 15:19, Flavio Leitner: > > The SET_ETHTOOL_OPS has been removed from upstream, so it > > breaks the dpdk build with recent kernels. > > > > Signed-off-by: Flavio Leitner > > You are removing SET_ETHTOOL_OPS calls. Yes. > In a previous patch, Aaro Koskinen made the choice to redefine the macro > in kcompat files. I missed that one. > I don't know what will be the choice of Intel in the sourceforge base driver. > So I've applied Aaro's patch as there are less modifications of the base > driver: > http://dpdk.org/browse/dpdk/commit/?id=e0b7ca0c0383411 Since the macro is a simple pointer assignment, I didn't see any reason for keeping it around. But maybe I am missing something. fbl