From mboxrd@z Thu Jan  1 00:00:00 1970
From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Subject: Re: [PATCH] librte_pmd_packet: add PMD for
 AF_PACKET-based virtual devices
Date: Mon, 14 Jul 2014 13:53:31 -0400
Message-ID: <20140714175330.GH27848@tuxdriver.com>
References: <1405024369-30058-1-git-send-email-linville@tuxdriver.com>
 <13642580.3DAGicjMse@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <13642580.3DAGicjMse@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Sat, Jul 12, 2014 at 12:30:34AM +0200, Thomas Monjalon wrote:
> About the form of the patch, I have 2 comments:
> 
> 1) A doc explaining the design, the dependencies and how it can be used would 
> be a great help. Could you write it in rst format?

What is rst format?  Are there other examples in the repository?

> 2) checkpatch.pl returns these errors:
> 
> ERROR:SPACING: space required before the open parenthesis '('
> #468: FILE: lib/librte_pmd_packet/rte_eth_packet.c:250:
> +               if(sockfd != -1)
> 
> ERROR:SPACING: space required before the open parenthesis '('
> #471: FILE: lib/librte_pmd_packet/rte_eth_packet.c:253:
> +               if(sockfd != -1)
> 
> ERROR:SPACING: spaces required around that '=' (ctx:VxV)
> #712: FILE: lib/librte_pmd_packet/rte_eth_packet.c:494:
> +               ifr.ifr_name[ifnamelen]='\0';

OK.  FWIW, at least the first two are slightly changed from what was
copied from the PCAP driver.  The other probably was a cut-n-paste
error from another source.

I'll post a V2 shortly...

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org			might be all we have.  Be ready.