From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/3] ether: Update field name and description for queue start Date: Tue, 22 Jul 2014 10:43:21 -0700 Message-ID: <20140722104321.6107c937@haswell> References: <1406015252-27804-1-git-send-email-changchun.ouyang@intel.com> <1406015252-27804-2-git-send-email-changchun.ouyang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Ouyang Changchun Return-path: In-Reply-To: <1406015252-27804-2-git-send-email-changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Tue, 22 Jul 2014 15:47:30 +0800 Ouyang Changchun wrote: > + /**< If rx_enable_queue is true, rte_eth_dev_rx_queue_start must be > + invocated after rte_eth_dev_start's invocation to start RX for > + one queue, and rte_eth_dev_rx_queue_start instead of > + rte_eth_dev_start is responsible for allocating mbuf from > + mempool and setup the DMA physical address. It is useful in > + such scenario: buffer address is not available at the point of > + rte_eth_dev_start's invocation but available later, e.g. in > + VHOST zero copy case, the buffer address to be setup DMA > + address is available only after one VM startup. */ Good documentation about semantics is really valuable as long as it kept up to date. In this case, the comment stands out which is not a good thing. An explanation this long belongs in documentation not in code. Alternatively, if it is this hard to explain maybe it isn't the right design :-)