From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/2] igb_uio: fix compability on old kernel Date: Sat, 23 Aug 2014 08:14:53 -0700 Message-ID: <20140823081453.6e3ae5d7@uryu.home.lan> References: <20140725103627.4ca989b7@haswell.linuxnetplumber.net> <9317787.qKVt3oyQbN@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Robert Sanford Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Fri, 22 Aug 2014 14:09:35 -0400 Robert Sanford wrote: > This is what we came up with. It works for us. In our kernel headers' > linux/pci.h, pci_num_vf is enclosed within "#ifdef CONFIG_PCI_IOV/#endif"; > pci_intx_mask_supported and pci_check_and_mask_intx are enclosed within > "#ifdef HAVE_PCI_SET_MWI/#endif". > > What do you think? Maybe we can just get rid of kernel version checks all together and just use the HAVE_ checks. I will test on stock 2.6.32.