From: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
To: Jay Rolette <rolette-bIuJOMs36aleGPcbtGPokg@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH 01/11] ixgbe: clean log messages
Date: Wed, 27 Aug 2014 11:06:57 -0700 [thread overview]
Message-ID: <20140827110657.557e0368@urahara> (raw)
In-Reply-To: <CADNuJVqKAPqXtZziEfwGa0iLsEg0N9ujFC_6ZbA2z5D2GDat9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, 27 Aug 2014 08:53:46 -0500
Jay Rolette <rolette-bIuJOMs36aleGPcbtGPokg@public.gmane.org> wrote:
> The updated output is definitely an improvement, but if you'll go with the
> first solution you described (adding \n in the log macro), it works much
> better for products using DPDK. For developer use, I think it ends up being
> a wash either way.
Also for driver consistency, all drivers must do the same thing. I.e the PMD_INIT_LOG
macro should either add or not add newline in the same way in all drivers.
I fixed virtio and vmxnet3 by just taking extra newlines out of messages
and leaving the macro alone.
next prev parent reply other threads:[~2014-08-27 18:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 14:09 [PATCH 00/11] cleanup logs in main PMDs David Marchand
[not found] ` <1409062162-19575-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-08-26 14:09 ` [PATCH 01/11] ixgbe: clean log messages David Marchand
[not found] ` <1409062162-19575-2-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-08-26 14:23 ` Jay Rolette
[not found] ` <CADNuJVruACvGgoSyN+aWOzPfvJrNPqsvAxwCvs2TxwRbhW+vyw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-26 14:55 ` David Marchand
[not found] ` <CALwxeUtqN+vZnHODvNgV7FvGGAKTtr7x2gxnoPosbcJx73sx9Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-27 13:53 ` Jay Rolette
[not found] ` <CADNuJVqKAPqXtZziEfwGa0iLsEg0N9ujFC_6ZbA2z5D2GDat9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-27 18:06 ` Stephen Hemminger [this message]
2014-08-29 7:45 ` David Marchand
2014-08-26 14:09 ` [PATCH 02/11] ixgbe: always log init messages David Marchand
2014-08-26 14:09 ` [PATCH 03/11] ixgbe: add a message when forcing scatter mode David Marchand
2014-08-26 14:09 ` [PATCH 04/11] ixgbe: add log messages when rx bulk mode is not usable David Marchand
2014-08-26 14:09 ` [PATCH 05/11] i40e: clean log messages David Marchand
2014-08-26 14:09 ` [PATCH 06/11] i40e: always log init messages David Marchand
2014-08-26 14:09 ` [PATCH 07/11] i40e: add log messages when rx bulk mode is not usable David Marchand
2014-08-26 14:09 ` [PATCH 08/11] e1000: clean log messages David Marchand
2014-08-26 14:09 ` [PATCH 09/11] e1000: always log init messages David Marchand
2014-08-26 14:09 ` [PATCH 10/11] e1000: add a message when forcing scatter mode David Marchand
2014-08-26 14:09 ` [PATCH 11/11] eal: set log level from command line David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140827110657.557e0368@urahara \
--to=stephen-otpzqlsittunbdjkjebofr2eb7je58tq@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=rolette-bIuJOMs36aleGPcbtGPokg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).