From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 01/11] ixgbe: clean log messages Date: Wed, 27 Aug 2014 11:06:57 -0700 Message-ID: <20140827110657.557e0368@urahara> References: <1409062162-19575-1-git-send-email-david.marchand@6wind.com> <1409062162-19575-2-git-send-email-david.marchand@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Jay Rolette Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Wed, 27 Aug 2014 08:53:46 -0500 Jay Rolette wrote: > The updated output is definitely an improvement, but if you'll go with the > first solution you described (adding \n in the log macro), it works much > better for products using DPDK. For developer use, I think it ends up being > a wash either way. Also for driver consistency, all drivers must do the same thing. I.e the PMD_INIT_LOG macro should either add or not add newline in the same way in all drivers. I fixed virtio and vmxnet3 by just taking extra newlines out of messages and leaving the macro alone.