From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Subject: Re: [PATCH 0/7] cleanup option parsing in bsd/linux eal
Date: Mon, 22 Sep 2014 08:43:27 -0400
Message-ID: <20140922124327.GD25406@hmsreliant.think-freely.org>
References: <1411375081-27986-1-git-send-email-david.marchand@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev-VfR2kkLFssw@public.gmane.org
To: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <1411375081-27986-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Mon, Sep 22, 2014 at 10:37:54AM +0200, David Marchand wrote:
> Following Neil comments, here is a patchset to rework the eal options parsing.
> I tried to have everything common to linux and bsd in a single file.
> 
> I ran a little make test on linux, it looks fine (at least I have as many fails
> as before my changes).
> 
> There is still work in this part, but I want to stop here.
> If anyone wants to continue ... :-)
> 
> 
> -- 
> David Marchand
> 
> David Marchand (7):
>   eal: remove unused --use-device option
>   eal: factorise unsupported option handling
>   eal: remove duplicate handling of white/black list
>   eal: fix checkpatch issues before moving code
>   eal: merge bsd and linux common options parsing
>   eal: rework long options parsing
>   eal: indent files
> 
>  lib/librte_eal/bsdapp/eal/Makefile          |    1 +
>  lib/librte_eal/bsdapp/eal/eal.c             |  388 +++--------------------
>  lib/librte_eal/common/eal_common_options.c  |  392 +++++++++++++++++++++++
>  lib/librte_eal/common/include/eal_options.h |   84 +++++
>  lib/librte_eal/linuxapp/eal/Makefile        |    1 +
>  lib/librte_eal/linuxapp/eal/eal.c           |  457 +++++----------------------
>  6 files changed, 593 insertions(+), 730 deletions(-)
>  create mode 100644 lib/librte_eal/common/eal_common_options.c
>  create mode 100644 lib/librte_eal/common/include/eal_options.h
> 
> -- 
> 1.7.10.4
> 
> 
Series
ACK