From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH] rte_mempool_dump() crashes with NULL rte_mempool pointer. Date: Sun, 28 Sep 2014 08:25:17 -0400 Message-ID: <20140928122516.GA30445@localhost.localdomain> References: <20140928003719.GA27849@localhost.localdomain> <20140928015504.GA28263@localhost.localdomain> <831919DA-CEF0-4DA5-AF5D-5B1067F7A602@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: "" To: "Wiles, Roger Keith" Return-path: Content-Disposition: inline In-Reply-To: <831919DA-CEF0-4DA5-AF5D-5B1067F7A602-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Sun, Sep 28, 2014 at 05:38:06AM +0000, Wiles, Roger Keith wrote: >=20 > On Sep 27, 2014, at 8:55 PM, Neil Horman wrote: >=20 > > On Sun, Sep 28, 2014 at 01:14:05AM +0000, Wiles, Roger Keith wrote: > >>=20 > >> On Sep 27, 2014, at 7:37 PM, Neil Horman wro= te: > >>=20 > >>> On Sat, Sep 27, 2014 at 06:35:01PM +0000, Wiles, Roger Keith wrote: > >>>>=20 > >>>> Check the FILE *f and rte_mempool *mp pointers for NULL and > >>>> return plus print out a message if RTE_LIBRTE_MEMPOOL_DEBUG is ena= bled. > >>>>=20 > >>>> Signed-off-by: Keith Wiles > >>>> --- > >>>> lib/librte_mempool/rte_mempool.c | 6 ++++++ > >>>> 1 file changed, 6 insertions(+) > >>>>=20 > >>>> diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool= /rte_mempool.c > >>>> index 332f469..efa6a6c 100644 > >>>> --- a/lib/librte_mempool/rte_mempool.c > >>>> +++ b/lib/librte_mempool/rte_mempool.c > >>>> @@ -765,6 +765,12 @@ rte_mempool_dump(FILE *f, const struct rte_me= mpool *mp) > >>>> unsigned common_count; > >>>> unsigned cache_count; > >>>>=20 > >>>> + if ( (f =3D=3D NULL) || (mp =3D=3D NULL) ) { > >>>> +#ifdef RTE_LIBRTE_MEMPOOL_DEBUG > >>>> + fprintf(stderr, "*** Called rte_mempool_dump(%p, %p) with = NULL argument\n", f, mp); > >>>> +#endif /* RTE_LIBRTE_MEMPOOL_DEBUG */ > >>>> + return; > >>>> + } > >>>> fprintf(f, "mempool <%s>@%p\n", mp->name, mp); > >>>> fprintf(f, " flags=3D%x\n", mp->flags); > >>>> fprintf(f, " ring=3D<%s>@%p\n", mp->ring->name, mp->ring); > >>>> --=20 > >>>> 2.1.0 > >>>>=20 > >>>>=20 > >>> Maybe use RTE_VERIFY instead? > >>> Neil > >>>=20 > >> I did not think it needs to panic as it is just a debug function and= returning would be fine by me, comments? > >> Do we have a similar RTE_VERIFY like function that does not panic? > >>=20 > > If we don't, it would seem useful to make one. It beats having to do= specific > > condition checking/error reporting. RTE_VERIFY_WARN or some such. > > Neil >=20 > I decided to just use RTE_VERIFY() instead of creating a new macro for = now, it seems this maybe an isolated case. I agree having RTE_VERIFY_WARN= () would be nice, but as I was writing the macro I wanted to return from = the function. For this routine =E2=80=98return=E2=80=99 would work as it = returns (void), but for other routines a value may need to be returned. >=20 Thats fine, you can do exactly what you need to do, just write the macro = to assert !!condition at the end, like this: #define RTE_VERIFY_WARN(condition) do { \ int ret =3D !!condition; \ if (ret) \ printf(); \ ret;\ } Then, you can use the macro as a conditional itself anywhere you want: int function(void *arguments) { if (RTE_VERIFY(arguments =3D=3D NULL)) return 1 .... } > Need a clean way to exit the routine without causing the macro to under= stand its return values. Just seem to become a bit messy at this point. M= ultiple macros for different return types or make the macros return a boo= lean value to be tested seemed to more complex then needed. See above, thats how all the Linux WARN_ON macros work. Neil > >=20 > >> Keith Wiles, Principal Technologist with CTO office, Wind River mobi= le 972-213-5533 >=20 > Keith Wiles, Principal Technologist with CTO office, Wind River mobile = 972-213-5533 >=20 >=20