From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y Date: Thu, 2 Oct 2014 20:52:41 -0400 Message-ID: <20141003005241.GA17181@localhost.localdomain> References: <1412265386-26291-1-git-send-email-sergio.gonzalez.monroy@intel.com> <20141002172634.GE4900@hmsreliant.think-freely.org> <20141002200420.GB29590@mhcomputing.net> <20141002202451.GF4900@hmsreliant.think-freely.org> <20141002211055.GA30270@mhcomputing.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev-VfR2kkLFssw@public.gmane.org To: Matthew Hall Return-path: Content-Disposition: inline In-Reply-To: <20141002211055.GA30270-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Thu, Oct 02, 2014 at 02:10:55PM -0700, Matthew Hall wrote: > On Thu, Oct 02, 2014 at 04:24:51PM -0400, Neil Horman wrote: > > This seems somewhat irrelevant to the patch. The default configuration is > > already the way you want it to be, shared library performance is actually very > > close to static performance, and yes, people can choose how they want to build. > > Not sure what point your trying to make here. > > Neil > > According to my reading, one of the subpatches threatened to disable the > single static libs when the grouped one is built. If you are working with > multiple DPDK apps, and one expects COMBINE_LIBS and the other does not, you > can't use both with the same copy of DPDK anymore if that subpatch gets > committed. > Ah, sorry, I misread, and thought you were advoating for making static builds the default over dynamic builds, which made no sense to me, as that was already the case. Neil > Matthew. >