From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] Pass CC option when building kernel modules
Date: Thu, 9 Oct 2014 09:10:04 +0100
Message-ID: <20141009081004.GA14308@BRICHA3-MOBL>
References: <1412611022-8278-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <8311103.0CSzmCek1E@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <8311103.0CSzmCek1E@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Wed, Oct 08, 2014 at 07:15:04PM +0200, Thomas Monjalon wrote:
> 2014-10-06 16:57, Sergio Gonzalez Monroy:
> > At least on kernels 3.15 or newer, DPDK build is broken for CLANG target.
> > The issue is that the kernel build system sets the flags before including
> > DPDK makefile and therefore assumes the incorrect compiler.
> > 
> > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> > --- a/mk/rte.module.mk
> > +++ b/mk/rte.module.mk
> > @@ -78,7 +78,7 @@ build: _postbuild
> >  $(MODULE).ko: $(SRCS_LINKS)
> >  	@if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi
> >  	@$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \
> > -		CROSS_COMPILE=$(CROSS)
> > +		CC=$(KERNELCC) CROSS_COMPILE=$(CROSS)
> 
> > --- a/mk/target/generic/rte.vars.mk
> > +++ b/mk/target/generic/rte.vars.mk
> > @@ -149,4 +149,6 @@ endif
> >  export CFLAGS
> >  export LDFLAGS
> >  
> > +else # ! ifeq ($(KERNELRELEASE),)
> > +CC = $(KERNELCC)
> >  endif
> 
> Why is it needed here? Setting CC in rte.module.mk is not sufficient?
> 
Right now, no it's not, and that's what is causing the error. However, we 
maybe can look and see if we moved the definition in rte.module.mk we might 
get the same effect.

/Bruce

> Thanks
> -- 
> Thomas