From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergio Gonzalez Monroy Subject: Re: [PATCH] Pass verbose flag to kernel module Date: Thu, 9 Oct 2014 10:37:13 +0100 Message-ID: <20141009093713.GB23978@sivswdev02.ir.intel.com> References: <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1731940.NUuDDJsRCL@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: Content-Disposition: inline In-Reply-To: <1731940.NUuDDJsRCL@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Wed, Oct 08, 2014 at 07:05:32PM +0200, Thomas Monjalon wrote: > Hi Sergio, > > 2014-10-06 17:09, Sergio Gonzalez Monroy: > > --- a/mk/rte.module.mk > > +++ b/mk/rte.module.mk > > @@ -78,7 +78,7 @@ build: _postbuild > > $(MODULE).ko: $(SRCS_LINKS) > > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ > > - CROSS_COMPILE=$(CROSS) > > + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS) > > Please could you explain why it is needed? > The variable V should be inherited by the recursive make. > It's working without your patch in my test. > Hi Thomas, You are right. If you set V=1 in the commmand line it will inherit and pass it down. In the curent framework, we do not force V to be 1, just to be defined (coud be V=y or V=enable, etc). This patch was just forcing the value to be 1 as it is the required value for the kernel makefiles. It is not a big deal and we could approach this by specifiying on the docs to be V=1 or any other way you think more appropiate? Thanks, Sergio > -- > Thomas