From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthew Hall <mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
Subject: "TX WTHRESH must be set to 0 if tx_rs_thresh is greater
	than 1"
Date: Sat, 18 Oct 2014 15:50:02 -0700
Message-ID: <20141018225002.GA17115@mhcomputing.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
To: dev-VfR2kkLFssw@public.gmane.org
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
Content-Disposition: inline
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hello,

I'm just trying to understand what you're supposed to do about this error to 
get the optiomal configuration / performance. The error message and comments 
seem like they're designed for Intel ethernet driver hackers not security 
hackers like myself! ;-)

Note: I'm trying out the Intel 82545EM in VirtualBox because the virtio-net 
approach didn't work, for reasons I enumerated in some previous mails.

    /*
     * If rs_bit_thresh is greater than 1, then TX WTHRESH should be
     * set to 0. If WTHRESH is greater than zero, the RS bit is ignored
     * by the NIC and all descriptors are written back after the NIC
     * accumulates WTHRESH descriptors.
     */
    if (tx_conf->tx_thresh.wthresh != 0 && tx_rs_thresh != 1) {
        RTE_LOG(ERR, PMD, "TX WTHRESH must be set to 0 if "
            "tx_rs_thresh is greater than 1. (tx_rs_thresh=%u "
            "port=%d queue=%d)\n", (unsigned int)tx_rs_thresh,
                (int)dev->data->port_id, (int)queue_idx);
        return -(EINVAL);
    }

Thanks,
Matthew.