From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping Date: Wed, 22 Oct 2014 19:09:33 +0530 Message-ID: <20141022190933.44549786@uryu.home.lan> References: <1413181389-14887-1-git-send-email-yongwang@vmware.com> <1413181389-14887-2-git-send-email-yongwang@vmware.com> <20141013113146.202b5eb3@uryu.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Yong Wang Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Mon, 13 Oct 2014 18:42:18 +0000 Yong Wang wrote: > Are you referring to the patch as a whole or your comment is about the reset of vlan_tci on the "else" (no vlan tags stripped) path? I am not sure I get your comments here. This patch simply fixes a bug on the rx vlan stripping path (where valid vlan_tci stripped is overwritten unconditionally later on the rx path in the original vmxnet3 pmd driver). All the other pmd drivers are doing the same thing in terms of translating descriptor status to rte_mbuf flags for vlan stripping. I was thinking that there are many fields in a pktmbuf and rather than individually setting them (like tci). The code should call the common rte_pktmbuf_reset before setting the fields. That way when someone adds a field to mbuf they don't have to chasing through every driver that does it's own initialization.