From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH 3/7] ENIC PMD Makefile Date: Mon, 10 Nov 2014 06:20:13 -0500 Message-ID: <20141110112013.GA26613@hmsreliant.think-freely.org> References: <1415390747-9532-1-git-send-email-ssujith@cisco.com> <1415390747-9532-4-git-send-email-ssujith@cisco.com> <20141107113449.GC25469@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Sujith Sankar (ssujith)" Return-path: Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Mon, Nov 10, 2014 at 09:59:45AM +0000, Sujith Sankar (ssujith) wrote: > Neil, >=20 > If I move the DPDK patch that accommodates ENIC PMD (that is the one th= at > patches lib/Makefile) to the last in the series, builds between commits > would succeed, wouldn=B9t it? Moving that to the last is anyway needed= . >=20 correct, yes. Neil > Thanks, > -Sujith >=20 > On 07/11/14 9:16 pm, "Sujith Sankar (ssujith)" wrot= e: >=20 > >Hi Neil, > > > >Thanks for the comments. I shall work on the modifications that you h= ave > >suggested and get back with V2. > > > >Regards, > >-Sujith > > > >On 07/11/14 5:04 pm, "Neil Horman" wrote: > > > >>On Sat, Nov 08, 2014 at 01:35:43AM +0530, Sujith Sankar wrote: > >>> Signed-off-by: Sujith Sankar > >>> --- > >>> lib/librte_pmd_enic/Makefile | 66 > >>>++++++++++++++++++++++++++++++++++++++++++++ > >>> 1 file changed, 66 insertions(+) > >>> create mode 100644 lib/librte_pmd_enic/Makefile > >>>=20 > >>> diff --git a/lib/librte_pmd_enic/Makefile > >>>b/lib/librte_pmd_enic/Makefile > >>> new file mode 100644 > >>> index 0000000..7605a8f > >>> --- /dev/null > >>> +++ b/lib/librte_pmd_enic/Makefile > >>> @@ -0,0 +1,66 @@ > >>> +# BSD LICENSE > >>> +#=20 > >>> +# Copyright(c) 2010-2013 Intel Corporation. All rights reserved. > >>> +# All rights reserved. > >>> +#=20 > >>> +# Redistribution and use in source and binary forms, with or wit= hout > >>> +# modification, are permitted provided that the following condit= ions > >>> +# are met: > >>> +#=20 > >>> +# * Redistributions of source code must retain the above copyr= ight > >>> +# notice, this list of conditions and the following disclaim= er. > >>> +# * Redistributions in binary form must reproduce the above > >>>copyright=20 > >>> +# notice, this list of conditions and the following disclaim= er > >>>in=20 > >>> +# the documentation and/or other materials provided with the > >>> +# distribution. > >>> +# * Neither the name of Intel Corporation nor the names of its > >>> +# contributors may be used to endorse or promote products > >>>derived=20 > >>> +# from this software without specific prior written permissi= on. > >>> +#=20 > >>> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND > >>>CONTRIBUTORS=20 > >>> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT = NOT > >>> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITN= ESS > >>>FOR=20 > >>> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE > >>>COPYRIGHT=20 > >>> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, > >>>INCIDENTAL,=20 > >>> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT N= OT > >>> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS = OF > >>>USE,=20 > >>> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND= ON > >>>ANY=20 > >>> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR > >>>TORT=20 > >>> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF = THE > >>>USE=20 > >>> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH > >>>DAMAGE. > >>> +#=20 > >>> + > >>> +include $(RTE_SDK)/mk/rte.vars.mk > >>> + > >>> +# > >>> +# library name > >>> +# > >>> +LIB =3D librte_pmd_enic.a > >>> + > >>> +CFLAGS +=3D -I$(RTE_SDK)/lib/librte_hash/ > >>> +CFLAGS +=3D -O3 -Wno-deprecated > >>> + > >>> +VPATH +=3D $(RTE_SDK)/lib/librte_pmd_enic/src > >>> + > >>> +# > >>> +# all source are stored in SRCS-y > >>> +# > >>> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D enic_main.c > >>> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D enic_clsf.c > >>> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D vnic_cq.c > >>> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D vnic_wq.c > >>> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D vnic_dev.c > >>> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D vnic_intr.c > >>> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D vnic_rq.c > >>> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D enic_etherdev.c > >>> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D enic_res.c > >>> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D vnic_rss.c > >>> + > >>> + > >>> +# this lib depends upon: > >>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D lib/librte_eal > >>>lib/librte_ether > >>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D lib/librte_mempool > >>>lib/librte_mbuf > >>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D lib/librte_net > >>>lib/librte_malloc > >>> + > >>> +include $(RTE_SDK)/mk/rte.lib.mk > >>> + > >>> --=20 > >>> 1.9.1 > >>>=20 > >>>=20 > >> > >>Make this the last patch in your series, and merge it with the chunk = from > >>the > >>last patch that adds the enic directory to the lib/Makefile, so that = a > >>bisect > >>will build between these commits. > >> > >>Neil > >> > > >=20 >=20