From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] cmdline: Fix broken functionality in FreeBSD Date: Thu, 20 Nov 2014 17:19:19 +0000 Message-ID: <20141120171919.GA9292@bricha3-MOBL3> References: <1416493033-13450-1-git-send-email-sergio.gonzalez.monroy@intel.com> <20141120142040.GE2609@hmsreliant.think-freely.org> <91383E96CE459D47BCE92EFBF5CE73B004EC5751@IRSMSX108.ger.corp.intel.com> <20141120170340.GF2609@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Neil Horman Return-path: Content-Disposition: inline In-Reply-To: <20141120170340.GF2609-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Thu, Nov 20, 2014 at 12:03:40PM -0500, Neil Horman wrote: > On Thu, Nov 20, 2014 at 04:42:23PM +0000, Gonzalez Monroy, Sergio wrote: > > > From: Neil Horman [mailto:nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org] > > > Sent: Thursday, November 20, 2014 2:21 PM > > > On Thu, Nov 20, 2014 at 02:17:13PM +0000, Sergio Gonzalez Monroy wrote: > > > > Some features of the cmdline were broken in FreeBSD as a result of > > > > termios not being compiled. > > > > > > > > Signed-off-by: Sergio Gonzalez Monroy > > > > > > > > > > Not sure I understand the changelog above. You're removing ifdefs below > > > which makes sense, but are you now assuming that BSD will be built with > > > termios support, or do you need to add some alternate dependency check > > > during the configuration of DPDK? > > > Neil > > > > > Yes, I was assuming that BSD has termios support. > > Is it not a fair assumption? > > > No, I think its a perfectly fair assumption. I was just trying to understand > the history of the ifdefs there. Sounds like it was a dumb idea to intiially > ifdef the termios stuff out way back when. > The ifdef probably dates from when there were just two versions of DPDK: linux and baremetal. Guess which one didn't have the termios support :-) /Bruce > Acked-by: Neil Horman > > > Sergio > >