dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Sujith Sankar <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2] enicpmd: replace the type u_int* with uint* to remove compilation errors on a few platforms
Date: Fri, 28 Nov 2014 13:48:10 +0000	[thread overview]
Message-ID: <20141128134809.GA5828@bricha3-MOBL3> (raw)
In-Reply-To: <1417167499-4847-1-git-send-email-ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>

On Fri, Nov 28, 2014 at 03:08:19PM +0530, Sujith Sankar wrote:
> ENIC PMD was giving compilation errors on ppc_64-power8-linuxapp-gcc because
> of types such as u_int32_t.  This patch replaces all those with uint32_t and
> similar ones.
> 
> Reported-by: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Sujith Sankar <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
> ---

Thanks for the patch to change these. Can I also suggest that you try compilation
with the clang compiler too, as I get a number of errors reported by that compiler
when I try compiling up the librte_pmd_enic folder.

Regards,
/Bruce

  parent reply	other threads:[~2014-11-28 13:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28  9:38 [PATCH v2] enicpmd: replace the type u_int* with uint* to remove compilation errors on a few platforms Sujith Sankar
     [not found] ` <1417167499-4847-1-git-send-email-ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2014-11-28 10:17   ` Thomas Monjalon
2014-11-28 10:21     ` Sujith Sankar (ssujith)
     [not found]       ` <D09E4A20.29090%ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2014-11-28 10:28         ` Thomas Monjalon
2014-11-28 13:48   ` Bruce Richardson [this message]
2014-11-28 15:50   ` David Marchand
2014-11-28 15:52   ` Bruce Richardson
2014-11-28 16:00     ` Thomas Monjalon
2014-11-28 16:01     ` Sujith Sankar (ssujith)
     [not found]       ` <D09E9992.290F7%ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2014-11-28 16:06         ` Bruce Richardson
2014-11-28 16:16           ` Sujith Sankar (ssujith)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141128134809.GA5828@bricha3-MOBL3 \
    --to=bruce.richardson-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).