From: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Thomas Monjalon
<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] scripts: fix symbol overriding in configuration files
Date: Fri, 28 Nov 2014 13:56:04 +0000 [thread overview]
Message-ID: <20141128135604.GB5828@bricha3-MOBL3> (raw)
In-Reply-To: <4256507.tIOyuODinC@xps13>
On Thu, Nov 27, 2014 at 10:17:22AM -0800, Thomas Monjalon wrote:
> > When redefining the same symbol in configuration (basically after an inclusion),
> > we need to undefine the previous symbol to avoid "redefined" errors.
> >
> > Signed-off-by: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
>
> Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
>
> Applied
>
This patch doesn't seem to work on FreeBSD. I'm still investigating how to fix
it but right now compilation with gcc/clang on FreeBSD is broken due to the
config.h file having lines like the below in it :-(
/usr/home/bruce/dpdk.org/x86_64-native-bsdapp-clang/include/rte_config.h:3:21: fatal error: extra tokens at end of #undef directive [-Wextra-tokens]
#undef RTE_EXEC_ENVn#define RTE_EXEC_ENV "bsdapp"
I'll send on a fix as soon as I can.
Regards,
/Bruce
next prev parent reply other threads:[~2014-11-28 13:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 11:29 [PATCH] scripts: fix symbol overriding in configuration files David Marchand
[not found] ` <1417087745-9004-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-11-27 18:17 ` Thomas Monjalon
2014-11-28 13:56 ` Bruce Richardson [this message]
2014-11-28 14:06 ` David Marchand
[not found] ` <CALwxeUvRWYPmwSR4tuH9x8QYwR1AA6qnUarMu=wM-NrK+Aq-6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-28 14:37 ` Bruce Richardson
2014-11-28 14:43 ` Bruce Richardson
2014-11-28 14:49 ` David Marchand
[not found] ` <CALwxeUt+_0mnh1Z15ruBr5eB5UkAQSX_ZzWaoHnNgaMEt9NUkw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-28 14:59 ` Bruce Richardson
2014-11-28 15:41 ` David Marchand
[not found] ` <CALwxeUuUJPUvKnyAxGtyebuQX24dJSZPm8q4cLi3ODEYUdwY-g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-28 15:42 ` [PATCH] scripts: fix newline character in sed expression David Marchand
[not found] ` <1417189364-23969-1-git-send-email-david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-11-28 15:49 ` Bruce Richardson
2014-11-28 16:05 ` Thomas Monjalon
2014-11-28 14:35 ` [PATCH] scripts: fix merged lines on FreeBSD in config.h Bruce Richardson
2014-11-28 11:35 ` [PATCH] scripts: fix symbol overriding in configuration files Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128135604.GB5828@bricha3-MOBL3 \
--to=bruce.richardson-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).