From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2] enicpmd: replace the type u_int* with
 uint* to remove compilation errors on a few platforms
Date: Fri, 28 Nov 2014 16:06:33 +0000
Message-ID: <20141128160633.GC4556@bricha3-MOBL3>
References: <1417167499-4847-1-git-send-email-ssujith@cisco.com>
 <20141128155229.GB4556@bricha3-MOBL3>
 <D09E9992.290F7%ssujith@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: "Sujith Sankar (ssujith)" <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <D09E9992.290F7%ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Fri, Nov 28, 2014 at 04:01:00PM +0000, Sujith Sankar (ssujith) wrote:
>=20
>=20
> On 28/11/14 9:22 pm, "Bruce Richardson" <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wr=
ote:
>=20
> >On Fri, Nov 28, 2014 at 03:08:19PM +0530, Sujith Sankar wrote:
> >> ENIC PMD was giving compilation errors on ppc_64-power8-linuxapp-gcc
> >>because
> >> of types such as u_int32_t.  This patch replaces all those with
> >>uint32_t and
> >> similar ones.
> >>=20
> >> Reported-by: David Marchand <david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> >> Signed-off-by: Sujith Sankar <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
> >
> >Acked-by: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >
> >This patch helps out with getting a clang compile on BSD. However, one
> >error
> >and a number of warnings remain that should be looked at in another pa=
tch.
> >The error is:
> >
> >dpdk.org/lib/librte_pmd_enic/enic_main.c:435:3: fatal error: non-void
> >function 'enic_rq_indicate_buf' should return a value [-Wreturn-type]
> >                return;
>=20
> Bruce, thanks for the comment.  I=B9ve not built enicpmd using clang
> compiler.
> I shall setup a BSD build with clang compiler and send a patch with
> necessary fixes.
> Could you please let me know the versions and flavours that you are usi=
ng?
>=20
> Thanks,
> -Sujith
>
Clang on a linux install gives the same errors, as far as I can see. What
I'm using is clang 3.4 on Fedora 20, and clang 3.3 on FreeBSD 10.=20

If you like, if you just fix clang on Linux compilation, I can check for =
any
additional errors on FreeBSD and get back to you on them, rather than you=
 having
to install a FreeBSD system right away.

/Bruce