From: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "Sujith Sankar (ssujith)"
<ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH] enicpd: Warnings and one error when built using clang compiler
Date: Mon, 1 Dec 2014 11:17:11 +0000 [thread overview]
Message-ID: <20141201111710.GC4856@bricha3-MOBL3> (raw)
In-Reply-To: <D0A247E2.292E0%ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
On Mon, Dec 01, 2014 at 11:06:43AM +0000, Sujith Sankar (ssujith) wrote:
>
> On 01/12/14 4:27 pm, "Bruce Richardson" <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>
> >On Sat, Nov 29, 2014 at 12:47:37PM +0530, Sujith Sankar wrote:
> >> This patch fixes the warnings and error reported by clang compiler on
> >>Linux.
> >>
> >> Reported-by: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >> Signed-off-by: Sujith Sankar <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
> >
> >This PMD now compiles up with clang on FreeBSD. The patch seems rather
> >large though,
> >are all these changes necessary for clang compilation?
>
> Yes. This patch has only the changes to fix compilation on clang, and it
> modifies enic code only.
>
> >
> >On the basis that this fixes the issue though:
> >
> >Acked-by: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> Thanks Bruce.
>
And thank you for providing a patch so quickly! :-)
/Bruce
next prev parent reply other threads:[~2014-12-01 11:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-29 7:17 [PATCH] enicpd: Warnings and one error when built using clang compiler Sujith Sankar
[not found] ` <1417245457-19609-1-git-send-email-ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2014-11-29 7:22 ` Sujith Sankar (ssujith)
[not found] ` <D09F7197.2912E%ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2014-11-29 11:17 ` Thomas Monjalon
2014-11-29 13:20 ` Sujith Sankar (ssujith)
2014-12-01 10:57 ` Bruce Richardson
2014-12-01 11:06 ` Sujith Sankar (ssujith)
[not found] ` <D0A247E2.292E0%ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2014-12-01 11:17 ` Bruce Richardson [this message]
2014-12-01 11:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201111710.GC4856@bricha3-MOBL3 \
--to=bruce.richardson-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).