From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] enicpd: Warnings and one error when built using clang compiler Date: Mon, 1 Dec 2014 11:17:11 +0000 Message-ID: <20141201111710.GC4856@bricha3-MOBL3> References: <1417245457-19609-1-git-send-email-ssujith@cisco.com> <20141201105756.GB4856@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Sujith Sankar (ssujith)" Return-path: Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Mon, Dec 01, 2014 at 11:06:43AM +0000, Sujith Sankar (ssujith) wrote: > > On 01/12/14 4:27 pm, "Bruce Richardson" wrote: > > >On Sat, Nov 29, 2014 at 12:47:37PM +0530, Sujith Sankar wrote: > >> This patch fixes the warnings and error reported by clang compiler on > >>Linux. > >> > >> Reported-by: Bruce Richardson > >> Signed-off-by: Sujith Sankar > > > >This PMD now compiles up with clang on FreeBSD. The patch seems rather > >large though, > >are all these changes necessary for clang compilation? > > Yes. This patch has only the changes to fix compilation on clang, and it > modifies enic code only. > > > > >On the basis that this fixes the issue though: > > > >Acked-by: Bruce Richardson > > Thanks Bruce. > And thank you for providing a patch so quickly! :-) /Bruce