From: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org"
<dev-VfR2kkLFssw@public.gmane.org>,
Hayato Momma <h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
Subject: Re: mk: fix LDFLAGS for shared lib
Date: Mon, 8 Dec 2014 10:01:54 -0500 [thread overview]
Message-ID: <20141208150154.GA3907@localhost.localdomain> (raw)
In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD05DCB8C6-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org>
On Wed, Dec 03, 2014 at 11:33:54PM +0000, Hiroshi Shimamoto wrote:
> From: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
>
> Only CPU_LDFLAGS is used in mk/rte.sharelib.mk.
> It should be LDFLAGS to build the library with correct linkage options.
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
> Reviewed-by: Hayato Momma <h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
>
> ---
> mk/rte.sharelib.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk
> index c0a811a..df6c268 100644
> --- a/mk/rte.sharelib.mk
> +++ b/mk/rte.sharelib.mk
> @@ -45,7 +45,7 @@ sharelib: $(LIB_ONE) FORCE
>
> OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o)
>
> -O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
> +O_TO_S = $(LD) $(LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
> O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight
> O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)")
> O_TO_S_CMD = "cmd_$@ = $(O_TO_S_STR)"
Does this continue to work on cross compiled arches (32 bit on 64 bit systems
and vice versa)? I have this recollection that something in CPU_LDFLAGS was
needed
Neil
next prev parent reply other threads:[~2014-12-08 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 23:33 [PATCH] mk: fix LDFLAGS for shared lib Hiroshi Shimamoto
[not found] ` <7F861DC0615E0C47A872E6F3C5FCDDBD05DCB8C6-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org>
2014-12-08 15:01 ` Neil Horman [this message]
[not found] ` <20141208150154.GA3907-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-12-08 23:44 ` Hiroshi Shimamoto
[not found] ` <7F861DC0615E0C47A872E6F3C5FCDDBD05DD32B1-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org>
2014-12-11 0:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141208150154.GA3907@localhost.localdomain \
--to=nhorman-2xusbdqka4r54taoqtywwq@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org \
--cc=h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).