From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH 14/15] app/test: turn off cpu flag checks for tile architecture Date: Tue, 9 Dec 2014 10:03:21 -0500 Message-ID: <20141209150321.GC28871@hmsreliant.think-freely.org> References: <1418029178-25162-1-git-send-email-zlu@ezchip.com> <1418029178-25162-15-git-send-email-zlu@ezchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev-VfR2kkLFssw@public.gmane.org To: Zhigang Lu Return-path: Content-Disposition: inline In-Reply-To: <1418029178-25162-15-git-send-email-zlu-d5a29ZRxExrQT0dZR+AlfA@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Mon, Dec 08, 2014 at 04:59:37PM +0800, Zhigang Lu wrote: > Tile processor doesn't have CPU flag hardware registers, so this patch > turns off cpu flag checks for tile. > > Signed-off-by: Zhigang Lu > Signed-off-by: Cyril Chemparathy > --- > app/test/test_cpuflags.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test/test_cpuflags.c b/app/test/test_cpuflags.c > index 5aeba5d..da93af5 100644 > --- a/app/test/test_cpuflags.c > +++ b/app/test/test_cpuflags.c > @@ -113,7 +113,7 @@ test_cpuflags(void) > > printf("Check for ICACHE_SNOOP:\t\t"); > CHECK_FOR_FLAG(RTE_CPUFLAG_ICACHE_SNOOP); > -#else > +#elif !defined(RTE_ARCH_TILE) > printf("Check for SSE:\t\t"); > CHECK_FOR_FLAG(RTE_CPUFLAG_SSE); > Please stop this. It doesn't make sense for a library that supports multiple arches, we need some way to generically test for flags that doesn't involve forcing applications to do ton's of ifdeffing. Perhaps rte_cpu_get_flag_enabled needs to do a flag table lookup based on the detected arch at run time, and return the appropriate response. In the case of tile, it can just be an empty table, so 0 is always returned. But making an application responsible for doing arch checks is a guarantee to write non-portable applications Neil > -- > 2.1.2 > >